mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
134 lines
4.1 KiB
Python
134 lines
4.1 KiB
Python
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import json
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
SCRIPT_PATH = (
|
|
Path(__file__).resolve().parents[2]
|
|
/ "optional-skills"
|
|
/ "productivity"
|
|
/ "telephony"
|
|
/ "scripts"
|
|
/ "telephony.py"
|
|
)
|
|
|
|
|
|
def load_module():
|
|
spec = importlib.util.spec_from_file_location("telephony_skill", SCRIPT_PATH)
|
|
module = importlib.util.module_from_spec(spec)
|
|
assert spec.loader is not None
|
|
sys.modules[spec.name] = module
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
def test_save_twilio_writes_env_and_state(tmp_path: Path, monkeypatch):
|
|
mod = load_module()
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
|
|
|
|
result = mod.save_twilio(
|
|
"AC123",
|
|
"secret-token",
|
|
phone_number="+1 (702) 555-1234",
|
|
phone_sid="PN123",
|
|
)
|
|
|
|
env_text = (tmp_path / ".hermes" / ".env").read_text(encoding="utf-8")
|
|
state = json.loads((tmp_path / ".hermes" / "telephony_state.json").read_text(encoding="utf-8"))
|
|
|
|
assert result["success"] is True
|
|
assert "TWILIO_ACCOUNT_SID=AC123" in env_text
|
|
assert "TWILIO_AUTH_TOKEN=secret-token" in env_text
|
|
assert "TWILIO_PHONE_NUMBER=+17025551234" in env_text
|
|
assert "TWILIO_PHONE_NUMBER_SID=PN123" in env_text
|
|
assert state["twilio"]["default_phone_number"] == "+17025551234"
|
|
assert state["twilio"]["default_phone_sid"] == "PN123"
|
|
|
|
|
|
def test_upsert_env_updates_existing_values(tmp_path: Path):
|
|
mod = load_module()
|
|
env_path = tmp_path / ".env"
|
|
env_path.write_text("TWILIO_PHONE_NUMBER=+15550000000\nOTHER=keep\n", encoding="utf-8")
|
|
|
|
mod._upsert_env_file(
|
|
{
|
|
"TWILIO_PHONE_NUMBER": "+15551112222",
|
|
"TWILIO_PHONE_NUMBER_SID": "PN999",
|
|
},
|
|
env_path=env_path,
|
|
)
|
|
|
|
env_text = env_path.read_text(encoding="utf-8")
|
|
assert "TWILIO_PHONE_NUMBER=+15551112222" in env_text
|
|
assert "TWILIO_PHONE_NUMBER_SID=PN999" in env_text
|
|
assert "OTHER=keep" in env_text
|
|
|
|
|
|
|
|
|
|
def test_twilio_buy_number_saves_env_and_state(tmp_path: Path):
|
|
mod = load_module()
|
|
state_path = tmp_path / "telephony_state.json"
|
|
env_path = tmp_path / ".env"
|
|
|
|
mod._twilio_request = lambda method, path, params=None, form=None: {
|
|
"sid": "PN111",
|
|
"phone_number": "+17025550123",
|
|
"friendly_name": "Test Number",
|
|
"capabilities": {"voice": True, "sms": True},
|
|
}
|
|
|
|
result = mod._twilio_buy_number(
|
|
"+17025550123",
|
|
save_env=True,
|
|
state_path=state_path,
|
|
env_path=env_path,
|
|
)
|
|
|
|
state = json.loads(state_path.read_text(encoding="utf-8"))
|
|
env_text = env_path.read_text(encoding="utf-8")
|
|
|
|
assert result["phone_sid"] == "PN111"
|
|
assert state["twilio"]["default_phone_number"] == "+17025550123"
|
|
assert state["twilio"]["default_phone_sid"] == "PN111"
|
|
assert "TWILIO_PHONE_NUMBER=+17025550123" in env_text
|
|
assert "TWILIO_PHONE_NUMBER_SID=PN111" in env_text
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_diagnose_includes_decision_tree_and_saved_state(tmp_path: Path, monkeypatch):
|
|
mod = load_module()
|
|
hermes_home = tmp_path / ".hermes"
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
mod._save_state(
|
|
{
|
|
"version": 1,
|
|
"twilio": {
|
|
"default_phone_number": "+17025550123",
|
|
"last_inbound_message_sid": "SM123",
|
|
},
|
|
"vapi": {
|
|
"phone_number_id": "vapi-abc",
|
|
},
|
|
},
|
|
hermes_home / "telephony_state.json",
|
|
)
|
|
(hermes_home / ".env").parent.mkdir(parents=True, exist_ok=True)
|
|
(hermes_home / ".env").write_text(
|
|
"TWILIO_ACCOUNT_SID=AC123\nTWILIO_AUTH_TOKEN=token\nBLAND_API_KEY=bland\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
result = mod.diagnose()
|
|
|
|
assert result["providers"]["twilio"]["default_phone_number"] == "+17025550123"
|
|
assert result["providers"]["twilio"]["last_inbound_message_sid"] == "SM123"
|
|
assert result["providers"]["bland"]["configured"] is True
|
|
assert result["providers"]["vapi"]["phone_number_id"] == "vapi-abc"
|
|
assert any(item["use"] == "Twilio" for item in result["decision_tree"])
|