mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
73 lines
2.6 KiB
Python
73 lines
2.6 KiB
Python
"""Regression test: google-workspace SKILL.md must declare required_credential_files.
|
|
|
|
PR #9931 accidentally removed the required_credential_files header, which broke
|
|
credential file mounting in Docker/Modal remote backends (#16452). This test
|
|
prevents the regression from silently reappearing.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
|
|
SKILL_MD = (
|
|
Path(__file__).resolve().parents[2]
|
|
/ "skills/productivity/google-workspace/SKILL.md"
|
|
)
|
|
|
|
_EXPECTED_PATHS = {"google_token.json", "google_client_secret.json"}
|
|
|
|
|
|
def _parse_frontmatter(content: str) -> dict:
|
|
from agent.skill_utils import parse_frontmatter
|
|
|
|
fm, _ = parse_frontmatter(content)
|
|
return fm
|
|
|
|
|
|
class TestGoogleWorkspaceCredentialFiles:
|
|
def test_required_credential_files_present_in_skill_md(self):
|
|
content = SKILL_MD.read_text(encoding="utf-8")
|
|
fm = _parse_frontmatter(content)
|
|
entries = fm.get("required_credential_files")
|
|
assert entries, "required_credential_files missing from google-workspace SKILL.md"
|
|
assert isinstance(entries, list), "required_credential_files must be a list"
|
|
paths = {
|
|
(e["path"] if isinstance(e, dict) else e)
|
|
for e in entries
|
|
}
|
|
assert _EXPECTED_PATHS <= paths, (
|
|
f"Missing entries in required_credential_files: {_EXPECTED_PATHS - paths}"
|
|
)
|
|
|
|
def test_entries_are_registered_when_files_exist(self, tmp_path):
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "google_token.json").write_text("{}")
|
|
(hermes_home / "google_client_secret.json").write_text("{}")
|
|
|
|
from tools.credential_files import (
|
|
clear_credential_files,
|
|
get_credential_file_mounts,
|
|
register_credential_files,
|
|
)
|
|
|
|
clear_credential_files()
|
|
try:
|
|
content = SKILL_MD.read_text(encoding="utf-8")
|
|
fm = _parse_frontmatter(content)
|
|
entries = fm.get("required_credential_files", [])
|
|
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(hermes_home)}):
|
|
missing = register_credential_files(entries)
|
|
|
|
assert missing == [], f"Unexpected missing files: {missing}"
|
|
mounts = get_credential_file_mounts()
|
|
container_paths = {m["container_path"] for m in mounts}
|
|
assert "/root/.hermes/google_token.json" in container_paths
|
|
assert "/root/.hermes/google_client_secret.json" in container_paths
|
|
finally:
|
|
clear_credential_files()
|
|
|