mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
85 lines
2.9 KiB
Python
85 lines
2.9 KiB
Python
"""Regression tests for #61099: switch_model must reapply provider-specific
|
|
default headers when it rebuilds _client_kwargs from scratch.
|
|
|
|
Without _apply_client_headers_for_base_url() in the rebuild path, a /model
|
|
switch drops OpenRouter attribution headers (HTTP-Referer / X-Title → logs
|
|
show "Unknown") and, worse, functional headers like Kimi's User-Agent
|
|
sentinel (403 without it).
|
|
"""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from run_agent import AIAgent
|
|
from agent.context_compressor import ContextCompressor
|
|
|
|
|
|
def _make_agent(provider="copilot", base_url="https://api.githubcopilot.com") -> AIAgent:
|
|
"""Minimal AIAgent with a context_compressor, skipping __init__."""
|
|
agent = AIAgent.__new__(AIAgent)
|
|
|
|
agent.model = "claude-opus-4.8"
|
|
agent.provider = provider
|
|
agent.base_url = base_url
|
|
agent.api_key = "sk-primary"
|
|
agent.api_mode = "chat_completions"
|
|
agent.client = MagicMock()
|
|
agent.quiet_mode = True
|
|
agent._config_context_length = None
|
|
agent._client_kwargs = {"api_key": "sk-primary", "base_url": base_url}
|
|
|
|
compressor = ContextCompressor(
|
|
model=agent.model,
|
|
threshold_percent=0.50,
|
|
base_url=base_url,
|
|
api_key="sk-primary",
|
|
provider=provider,
|
|
quiet_mode=True,
|
|
config_context_length=None,
|
|
)
|
|
agent.context_compressor = compressor
|
|
agent._primary_runtime = {}
|
|
|
|
return agent
|
|
|
|
|
|
@patch("agent.model_metadata.get_model_context_length", return_value=131_072)
|
|
def test_switch_to_openrouter_reapplies_attribution_headers(mock_ctx_len):
|
|
"""Switching to an openrouter.ai base_url must attach the OpenRouter
|
|
attribution headers (HTTP-Referer / X-Title) to the rebuilt client
|
|
kwargs — not ship a bare api_key+base_url client (#61099)."""
|
|
agent = _make_agent(provider="copilot", base_url="https://api.githubcopilot.com")
|
|
|
|
agent.switch_model(
|
|
"deepseek/deepseek-chat",
|
|
"openrouter",
|
|
api_key="sk-or-new",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
)
|
|
|
|
headers = agent._client_kwargs.get("default_headers") or {}
|
|
assert "HTTP-Referer" in headers
|
|
assert headers.get("X-Title")
|
|
|
|
|
|
|
|
|
|
@patch("agent.model_metadata.get_model_context_length", return_value=131_072)
|
|
def test_switch_away_from_headered_provider_clears_stale_headers(mock_ctx_len):
|
|
"""Switching FROM a headered provider TO one with no URL-specific headers
|
|
must not carry the old provider's headers along."""
|
|
agent = _make_agent(provider="openrouter", base_url="https://openrouter.ai/api/v1")
|
|
agent._client_kwargs["default_headers"] = {
|
|
"HTTP-Referer": "https://hermes-agent.nousresearch.com",
|
|
"X-Title": "Hermes Agent",
|
|
}
|
|
|
|
agent.switch_model(
|
|
"MiniMax-M3",
|
|
"custom:minimax",
|
|
api_key="sk-minimax",
|
|
base_url="https://api.minimax.io/v1",
|
|
)
|
|
|
|
headers = agent._client_kwargs.get("default_headers") or {}
|
|
assert "HTTP-Referer" not in headers
|
|
assert "X-Title" not in headers
|