mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
61 lines
1.9 KiB
Python
61 lines
1.9 KiB
Python
"""Tests for tool call argument repair in the streaming assembly path.
|
|
|
|
The streaming path (run_agent._call_chat_completions) assembles tool call
|
|
deltas into full arguments. When a model truncates or malforms the JSON
|
|
(e.g. GLM-5.1 via Ollama), the assembly path used to pass the broken JSON
|
|
straight through — setting has_truncated_tool_args but NOT repairing it.
|
|
That triggered the truncation handler to kill the session with /new required.
|
|
|
|
The fix: repair arguments in the streaming assembly path using
|
|
_repair_tool_call_arguments() so repairable malformations (trailing commas,
|
|
unclosed brackets, Python None) don't kill the session.
|
|
"""
|
|
|
|
import json
|
|
|
|
from run_agent import _repair_tool_call_arguments
|
|
|
|
|
|
class TestStreamingAssemblyRepair:
|
|
"""Verify that _repair_tool_call_arguments is applied to streaming tool
|
|
call arguments before they're assembled into mock_tool_calls.
|
|
|
|
These tests verify the REPAIR FUNCTION itself works correctly for the
|
|
cases that arise during streaming assembly. Integration tests that
|
|
exercise the full streaming path are in run_agent.py's streaming tests.
|
|
"""
|
|
|
|
# -- Truncation cases (most common streaming failure) --
|
|
|
|
def test_truncated_object_no_close_brace(self):
|
|
"""Model stops mid-JSON, common with output length limits."""
|
|
raw = '{"command": "ls -la", "timeout": 30'
|
|
result = _repair_tool_call_arguments(raw, "terminal")
|
|
parsed = json.loads(result)
|
|
assert parsed["command"] == "ls -la"
|
|
assert parsed["timeout"] == 30
|
|
|
|
|
|
|
|
# -- Trailing comma cases (Ollama/GLM common) --
|
|
|
|
|
|
|
|
# -- Python None from model output --
|
|
|
|
|
|
# -- Empty arguments (some models emit empty string) --
|
|
|
|
def test_empty_string(self):
|
|
assert _repair_tool_call_arguments("", "test") == "{}"
|
|
|
|
|
|
# -- Already-valid JSON passes through unchanged --
|
|
|
|
|
|
# -- Extra closing brackets (rare but happens) --
|
|
|
|
|
|
# -- Real-world GLM-5.1 truncation pattern --
|
|
|
|
|