mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
139 lines
4.4 KiB
Python
139 lines
4.4 KiB
Python
"""Regression tests for the notice-spine (AgentNotice + emitter callbacks).
|
|
|
|
Covers:
|
|
A. _emit_notice / _emit_notice_clear emitter behaviour (bare AIAgent via
|
|
object.__new__ — same pattern as test_steer.py and test_file_mutation_verifier.py).
|
|
B. Constructor / init_agent signature threading.
|
|
C. TUI _agent_cbs notice binding — mirrors the status_callback tests already
|
|
in tests/test_tui_gateway_server.py.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import inspect
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from agent.credits_tracker import AgentNotice
|
|
from run_agent import AIAgent
|
|
|
|
|
|
# ── A. Emitter behaviour ─────────────────────────────────────────────────────
|
|
|
|
|
|
def _bare_agent() -> AIAgent:
|
|
"""Build an AIAgent without running __init__ (no heavy init required).
|
|
|
|
Only the two callback slots used by _emit_notice / _emit_notice_clear are
|
|
installed — mirrors the pattern in test_steer.py.
|
|
"""
|
|
agent = object.__new__(AIAgent)
|
|
agent.notice_callback = None
|
|
agent.notice_clear_callback = None
|
|
return agent
|
|
|
|
|
|
class TestEmitNotice:
|
|
def test_emit_notice_calls_callback_with_exact_notice(self):
|
|
agent = _bare_agent()
|
|
received = []
|
|
notice = AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
agent.notice_callback = received.append
|
|
agent._emit_notice(notice)
|
|
assert received == [notice]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── B. Constructor / init_agent signature threading ─────────────────────────
|
|
|
|
|
|
class TestSignatureThreading:
|
|
def test_agent_init_exposes_notice_callback(self):
|
|
sig = inspect.signature(AIAgent.__init__)
|
|
assert "notice_callback" in sig.parameters
|
|
|
|
|
|
|
|
|
|
|
|
# ── C. TUI _agent_cbs binding ────────────────────────────────────────────────
|
|
|
|
|
|
class TestAgentCbsNoticeBinding:
|
|
"""Mirror test_status_callback_emits_kind_and_text from test_tui_gateway_server.py."""
|
|
|
|
def test_notice_callback_emits_notification_show(self):
|
|
from tui_gateway import server
|
|
|
|
with patch("tui_gateway.server._emit") as mock_emit:
|
|
cbs = server._agent_cbs("sid123")
|
|
notice = AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
cbs["notice_callback"](notice)
|
|
|
|
mock_emit.assert_called_once_with(
|
|
"notification.show",
|
|
"sid123",
|
|
{
|
|
"text": "credits 90% used",
|
|
"level": "warn",
|
|
"kind": "sticky",
|
|
"ttl_ms": None,
|
|
"key": "credits.warn90",
|
|
"id": "n1",
|
|
},
|
|
)
|
|
|
|
def test_notice_callback_payload_is_full_snake_case_dict(self):
|
|
"""All six snake_case fields must be present in the payload — no extras,
|
|
no camelCase variants."""
|
|
from tui_gateway import server
|
|
|
|
captured = []
|
|
with patch("tui_gateway.server._emit", side_effect=lambda *a: captured.append(a)):
|
|
cbs = server._agent_cbs("sid123")
|
|
cbs["notice_callback"](
|
|
AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
)
|
|
|
|
assert len(captured) == 1
|
|
_event_type, _sid, payload = captured[0]
|
|
assert set(payload.keys()) == {"text", "level", "kind", "ttl_ms", "key", "id"}
|
|
|
|
|
|
|
|
def test_notice_clear_callback_event_type_is_notification_clear(self):
|
|
from tui_gateway import server
|
|
|
|
captured = []
|
|
with patch("tui_gateway.server._emit", side_effect=lambda *a: captured.append(a)):
|
|
cbs = server._agent_cbs("sid123")
|
|
cbs["notice_clear_callback"]("some.key")
|
|
|
|
assert captured[0][0] == "notification.clear"
|
|
assert captured[0][1] == "sid123"
|
|
assert captured[0][2] == {"key": "some.key"}
|