mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
43 lines
1.2 KiB
Python
43 lines
1.2 KiB
Python
"""Tests for per-turn reasoning extraction in AIAgent.run_conversation.
|
|
|
|
Verifies the reasoning field returned to display layers (CLI reasoning box,
|
|
gateway reasoning footer, TUI reasoning event) only reflects the CURRENT
|
|
turn's reasoning — never leaks from a prior turn — and is picked up
|
|
correctly when reasoning is attached to a tool-calling assistant step
|
|
rather than the final-answer assistant step.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
|
|
def _extract_last_reasoning(messages):
|
|
"""Replica of the extraction loop in run_agent.py (~line 13867).
|
|
|
|
Tests pin the loop's behaviour so that refactors can't silently
|
|
regress the per-turn semantic.
|
|
"""
|
|
last_reasoning = None
|
|
for msg in reversed(messages):
|
|
if msg.get("role") == "user":
|
|
break
|
|
if msg.get("role") == "assistant" and msg.get("reasoning"):
|
|
last_reasoning = msg["reasoning"]
|
|
break
|
|
return last_reasoning
|
|
|
|
|
|
def test_simple_turn_reasoning_present():
|
|
messages = [
|
|
{"role": "user", "content": "hello"},
|
|
{"role": "assistant", "content": "hi", "reasoning": "greeting the user"},
|
|
]
|
|
assert _extract_last_reasoning(messages) == "greeting the user"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|