mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
64 lines
2.4 KiB
Python
64 lines
2.4 KiB
Python
"""Tests for the display.credits_notices config gate on _emit_credits_notices.
|
|
|
|
The toggle suppresses notice EMISSION only — credits state capture and /usage
|
|
stay live. Uses the bare-AIAgent pattern (object.__new__) from test_notice_spine.py.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
from agent.credits_tracker import CreditsState
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _agent_with_state(*, paid_access: bool = False) -> AIAgent:
|
|
"""Bare agent with a depleted-shaped state that would normally emit."""
|
|
agent = object.__new__(AIAgent)
|
|
agent.notice_callback = None
|
|
agent.notice_clear_callback = None
|
|
agent._credits_state = CreditsState(paid_access=paid_access)
|
|
agent.model = ""
|
|
agent.base_url = ""
|
|
return agent
|
|
|
|
|
|
def _cfg(enabled):
|
|
return {"display": {"credits_notices": enabled}}
|
|
|
|
|
|
class TestCreditsNoticesToggle:
|
|
def test_disabled_emits_nothing(self):
|
|
agent = _agent_with_state()
|
|
received = []
|
|
agent.notice_callback = received.append
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(False)):
|
|
agent._emit_credits_notices()
|
|
assert received == []
|
|
|
|
|
|
|
|
def test_config_error_fails_open(self):
|
|
agent = _agent_with_state()
|
|
received = []
|
|
agent.notice_callback = received.append
|
|
with patch("hermes_cli.config.load_config", side_effect=RuntimeError("boom")):
|
|
agent._emit_credits_notices()
|
|
assert any(getattr(n, "key", None) == "credits.depleted" for n in received)
|
|
|
|
def test_toggle_cached_per_agent(self):
|
|
"""load_config is consulted once per agent, not once per emission."""
|
|
agent = _agent_with_state()
|
|
agent.notice_callback = lambda n: None
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(True)) as mock_load:
|
|
agent._emit_credits_notices()
|
|
agent._emit_credits_notices()
|
|
assert mock_load.call_count == 1
|
|
|
|
def test_disabled_state_still_cached_for_usage(self):
|
|
"""The gate stops emission only — get_credits_state still returns data."""
|
|
agent = _agent_with_state()
|
|
agent.notice_callback = lambda n: None
|
|
agent._credits_session_start_micros = None
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(False)):
|
|
agent._emit_credits_notices()
|
|
assert agent.get_credits_state() is not None
|