mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
130 lines
4.1 KiB
Python
130 lines
4.1 KiB
Python
"""Outbound-media tests for PhotonAdapter.
|
|
|
|
Photon ships outbound attachments via spectrum-ts' ``attachment()`` /
|
|
``voice()`` content builders, reached through the Node sidecar's
|
|
``/send-attachment`` endpoint. These tests stub ``_sidecar_call`` so we
|
|
can assert the endpoint + body shape each ``send_*`` override produces
|
|
without spawning Node or binding ports.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from typing import Any, Dict, List, Tuple
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.photon import adapter as photon_adapter
|
|
from plugins.platforms.photon.adapter import PhotonAdapter
|
|
|
|
|
|
def _make_adapter(monkeypatch: pytest.MonkeyPatch) -> PhotonAdapter:
|
|
monkeypatch.setenv("PHOTON_PROJECT_ID", "test-project-id")
|
|
monkeypatch.setenv("PHOTON_PROJECT_SECRET", "test-project-secret")
|
|
monkeypatch.delenv("PHOTON_WEBHOOK_SECRET", raising=False)
|
|
cfg = PlatformConfig(enabled=True, token="", extra={})
|
|
return PhotonAdapter(cfg)
|
|
|
|
|
|
def _capture_sidecar(adapter: PhotonAdapter) -> List[Tuple[str, Dict[str, Any]]]:
|
|
"""Replace ``_sidecar_call`` with a recorder that returns a fixed id."""
|
|
calls: List[Tuple[str, Dict[str, Any]]] = []
|
|
|
|
async def _fake_call(path: str, body: Dict[str, Any]) -> Dict[str, Any]:
|
|
calls.append((path, body))
|
|
return {"ok": True, "messageId": "msg-123"}
|
|
|
|
adapter._sidecar_call = _fake_call # type: ignore[assignment]
|
|
return calls
|
|
|
|
|
|
@pytest.fixture()
|
|
def real_file(tmp_path) -> str:
|
|
p = tmp_path / "photo.jpg"
|
|
p.write_bytes(b"\xff\xd8\xff\xe0fake-jpeg")
|
|
return str(p)
|
|
|
|
|
|
def _patch_safe_path(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""Make path validation a passthrough so tmp files outside the cache pass."""
|
|
monkeypatch.setattr(
|
|
PhotonAdapter,
|
|
"validate_media_delivery_path",
|
|
staticmethod(lambda p: p if os.path.exists(p) else None),
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_image_file_hits_attachment_endpoint(
|
|
monkeypatch: pytest.MonkeyPatch, real_file: str
|
|
) -> None:
|
|
_patch_safe_path(monkeypatch)
|
|
adapter = _make_adapter(monkeypatch)
|
|
calls = _capture_sidecar(adapter)
|
|
|
|
result = await adapter.send_image_file(
|
|
"any;-;+15551234567", real_file, caption="look"
|
|
)
|
|
|
|
assert result.success is True
|
|
assert result.message_id == "msg-123"
|
|
assert len(calls) == 1
|
|
path, body = calls[0]
|
|
assert path == "/send-attachment"
|
|
assert body["spaceId"] == "any;-;+15551234567"
|
|
assert body["path"] == real_file
|
|
assert body["kind"] == "attachment"
|
|
assert body["caption"] == "look"
|
|
assert body["mimeType"] == "image/jpeg" # inferred from .jpg
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_standalone_send_text_then_attachments(
|
|
monkeypatch: pytest.MonkeyPatch, tmp_path
|
|
) -> None:
|
|
_patch_safe_path(monkeypatch)
|
|
img = tmp_path / "a.png"
|
|
img.write_bytes(b"\x89PNG fake")
|
|
monkeypatch.setenv("PHOTON_SIDECAR_TOKEN", "tok")
|
|
|
|
posted: List[Tuple[str, Dict[str, Any]]] = []
|
|
|
|
class _Resp:
|
|
status_code = 200
|
|
|
|
@staticmethod
|
|
def json() -> Dict[str, Any]:
|
|
return {"ok": True, "messageId": "m-9"}
|
|
|
|
class _FakeClient:
|
|
def __init__(self, *a, **k):
|
|
pass
|
|
|
|
async def __aenter__(self):
|
|
return self
|
|
|
|
async def __aexit__(self, *a):
|
|
return False
|
|
|
|
async def post(self, url: str, json: Dict[str, Any], headers=None):
|
|
posted.append((url, json))
|
|
return _Resp()
|
|
|
|
monkeypatch.setattr(photon_adapter.httpx, "AsyncClient", _FakeClient)
|
|
|
|
cfg = PlatformConfig(enabled=True, token="", extra={})
|
|
result = await photon_adapter._standalone_send(
|
|
cfg,
|
|
"any;-;+1",
|
|
"hello",
|
|
media_files=[(str(img), False)],
|
|
)
|
|
|
|
assert result.get("success") is True
|
|
# First call is the text /send, second is /send-attachment.
|
|
assert posted[0][0].endswith("/send")
|
|
assert posted[0][1]["text"] == "hello"
|
|
assert posted[1][0].endswith("/send-attachment")
|
|
assert posted[1][1]["path"] == str(img)
|
|
assert posted[1][1]["kind"] == "attachment"
|
|
assert posted[1][1]["mimeType"] == "image/png"
|