mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
109 lines
3.6 KiB
Python
109 lines
3.6 KiB
Python
"""Tests for the TTS plugin picker surface in hermes_cli/tools_config.py (issue #30398).
|
|
|
|
Covers ``_plugin_tts_providers()`` and the ``_visible_providers()``
|
|
integration that injects plugin rows into the Text-to-Speech category.
|
|
|
|
Mirrors the structure of existing image_gen / browser picker tests.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent import tts_registry
|
|
from agent.tts_provider import TTSProvider
|
|
from hermes_cli import tools_config
|
|
|
|
|
|
class _FakeTTSProvider(TTSProvider):
|
|
def __init__(self, name: str, schema: dict | None = None):
|
|
self._name = name
|
|
self._schema = schema
|
|
|
|
@property
|
|
def name(self) -> str:
|
|
return self._name
|
|
|
|
def synthesize(self, text, output_path, **kw):
|
|
return output_path
|
|
|
|
def get_setup_schema(self):
|
|
if self._schema is not None:
|
|
return self._schema
|
|
return super().get_setup_schema()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_registry():
|
|
tts_registry._reset_for_tests()
|
|
yield
|
|
tts_registry._reset_for_tests()
|
|
|
|
|
|
class TestPluginTTSProviders:
|
|
"""``_plugin_tts_providers()`` returns picker-row dicts."""
|
|
|
|
|
|
|
|
|
|
def test_skips_providers_with_no_name(self):
|
|
"""Defense in depth: a provider with no .name attribute is skipped
|
|
rather than crashing the picker."""
|
|
|
|
class _NoName:
|
|
display_name = "Bogus"
|
|
def get_setup_schema(self):
|
|
return {"name": "Bogus"}
|
|
|
|
tts_registry._providers["bogus"] = _NoName() # type: ignore[assignment]
|
|
try:
|
|
rows = tools_config._plugin_tts_providers()
|
|
# Provider has no .name so the picker filters it out
|
|
assert all(r.get("tts_plugin_name") != "bogus" for r in rows)
|
|
finally:
|
|
tts_registry._providers.pop("bogus", None) # type: ignore[arg-type]
|
|
|
|
|
|
def test_minimal_schema_uses_display_name(self):
|
|
"""A provider with no setup_schema override gets a row built from
|
|
``display_name`` and ``name`` only."""
|
|
tts_registry.register_provider(_FakeTTSProvider(name="minimal"))
|
|
rows = tools_config._plugin_tts_providers()
|
|
assert len(rows) == 1
|
|
assert rows[0]["name"] == "Minimal" # display_name default
|
|
assert rows[0]["tts_provider"] == "minimal"
|
|
assert rows[0]["env_vars"] == []
|
|
|
|
|
|
|
|
class TestVisibleProvidersInjectsTTSPlugins:
|
|
"""``_visible_providers()`` injects plugin rows into the Text-to-Speech
|
|
category alongside the hardcoded built-in rows."""
|
|
|
|
def test_tts_category_includes_plugin_rows(self):
|
|
tts_registry.register_provider(_FakeTTSProvider(name="cartesia"))
|
|
|
|
tts_cat = tools_config.TOOL_CATEGORIES["tts"]
|
|
visible = tools_config._visible_providers(tts_cat, config={})
|
|
|
|
names = [row.get("name") for row in visible]
|
|
# Hardcoded rows (sample — check at least one is present)
|
|
assert "Microsoft Edge TTS" in names
|
|
# Plugin row injected at the end
|
|
assert "Cartesia" in names
|
|
|
|
# Plugin row has tts_provider key for write-path compat
|
|
plugin_rows = [r for r in visible if r.get("tts_plugin_name")]
|
|
assert len(plugin_rows) == 1
|
|
assert plugin_rows[0]["tts_provider"] == "cartesia"
|
|
|
|
def test_other_categories_unaffected_by_tts_plugins(self):
|
|
"""Registering a TTS plugin must not leak into the Image Generation
|
|
or Browser pickers."""
|
|
tts_registry.register_provider(_FakeTTSProvider(name="cartesia"))
|
|
|
|
img_cat = tools_config.TOOL_CATEGORIES["image_gen"]
|
|
visible = tools_config._visible_providers(img_cat, config={})
|
|
names = [row.get("name") for row in visible]
|
|
assert "Cartesia" not in names
|
|
|