mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
119 lines
3 KiB
Python
119 lines
3 KiB
Python
"""Tests for the teams_pipeline plugin CLI."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from argparse import ArgumentParser, Namespace
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from plugins.teams_pipeline.cli import register_cli, teams_pipeline_command
|
|
from plugins.teams_pipeline.store import TeamsPipelineStore
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
|
|
|
|
def _make_args(**kwargs):
|
|
defaults = {
|
|
"teams_pipeline_action": None,
|
|
"store_path": "",
|
|
"status": "",
|
|
"limit": 20,
|
|
"job_id": "",
|
|
"meeting_id": "",
|
|
"join_web_url": "",
|
|
"tenant_id": "",
|
|
"call_record_id": "",
|
|
"resource": "",
|
|
"notification_url": "",
|
|
"change_type": "updated",
|
|
"expiration": "",
|
|
"client_state": "",
|
|
"lifecycle_notification_url": "",
|
|
"latest_supported_tls_version": "v1_2",
|
|
"subscription_id": "",
|
|
"force_refresh": False,
|
|
"renew_within_hours": 24,
|
|
"extend_hours": 24,
|
|
"dry_run": False,
|
|
}
|
|
defaults.update(kwargs)
|
|
return Namespace(**defaults)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_show_prints_job_json(capsys, tmp_path):
|
|
store = TeamsPipelineStore(tmp_path / "teams_pipeline_store.json")
|
|
store.upsert_job(
|
|
"job-1",
|
|
{
|
|
"event_id": "evt-1",
|
|
"source_event_type": "updated",
|
|
"dedupe_key": "evt-1",
|
|
"status": "completed",
|
|
"meeting_ref": {"meeting_id": "meeting-1"},
|
|
},
|
|
)
|
|
|
|
teams_pipeline_command(
|
|
_make_args(
|
|
teams_pipeline_action="show",
|
|
job_id="job-1",
|
|
store_path=str(tmp_path / "teams_pipeline_store.json"),
|
|
)
|
|
)
|
|
out = capsys.readouterr().out
|
|
payload = json.loads(out)
|
|
assert payload["job_id"] == "job-1"
|
|
assert payload["meeting_ref"]["meeting_id"] == "meeting-1"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_validate_accepts_msgraph_credentials_for_graph_delivery(monkeypatch, capsys, tmp_path):
|
|
from gateway.config import Platform, PlatformConfig
|
|
|
|
monkeypatch.setenv("MSGRAPH_TENANT_ID", "tenant")
|
|
monkeypatch.setenv("MSGRAPH_CLIENT_ID", "client")
|
|
monkeypatch.setenv("MSGRAPH_CLIENT_SECRET", "secret")
|
|
|
|
gateway_config = SimpleNamespace(
|
|
platforms={
|
|
Platform.MSGRAPH_WEBHOOK: PlatformConfig(enabled=True, extra={}),
|
|
Platform("teams"): PlatformConfig(
|
|
enabled=True,
|
|
extra={
|
|
"delivery_mode": "graph",
|
|
"team_id": "team-1",
|
|
"channel_id": "channel-1",
|
|
},
|
|
),
|
|
}
|
|
)
|
|
monkeypatch.setattr(
|
|
"plugins.teams_pipeline.cli.load_gateway_config",
|
|
lambda: gateway_config,
|
|
)
|
|
|
|
teams_pipeline_command(
|
|
_make_args(
|
|
teams_pipeline_action="validate",
|
|
store_path=str(tmp_path / "teams_pipeline_store.json"),
|
|
)
|
|
)
|
|
payload = json.loads(capsys.readouterr().out)
|
|
assert payload["ok"] is True
|
|
assert payload["issues"] == []
|