mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
60 lines
1.6 KiB
Python
60 lines
1.6 KiB
Python
"""Generated service behavior for the opt-in systemd watchdog."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from gateway.config import GatewayConfig
|
|
from hermes_cli import gateway as gateway_cli
|
|
|
|
|
|
|
|
|
|
def test_positive_watchdog_config_generates_notify_unit(monkeypatch):
|
|
monkeypatch.setattr(
|
|
gateway_cli,
|
|
"load_gateway_config",
|
|
lambda: GatewayConfig.from_dict({"systemd_watchdog_seconds": 120}),
|
|
raising=False,
|
|
)
|
|
|
|
unit = gateway_cli.generate_systemd_unit(system=False)
|
|
|
|
assert "Type=notify" in unit
|
|
assert "NotifyAccess=main" in unit
|
|
assert "WatchdogSec=120s" in unit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_system_unit_reads_watchdog_from_target_home(tmp_path, monkeypatch):
|
|
caller_home = tmp_path / "caller"
|
|
target_home = tmp_path / "target"
|
|
caller_home.mkdir()
|
|
target_home.mkdir()
|
|
(caller_home / "config.yaml").write_text(
|
|
"gateway:\n systemd_watchdog_seconds: 0\n",
|
|
encoding="utf-8",
|
|
)
|
|
(target_home / "config.yaml").write_text(
|
|
"gateway:\n systemd_watchdog_seconds: 75\n",
|
|
encoding="utf-8",
|
|
)
|
|
monkeypatch.setenv("HERMES_HOME", str(caller_home))
|
|
monkeypatch.setattr(
|
|
gateway_cli,
|
|
"_system_service_identity",
|
|
lambda _user: ("service", "service", str(tmp_path / "account")),
|
|
)
|
|
monkeypatch.setattr(
|
|
gateway_cli,
|
|
"_hermes_home_for_target_user",
|
|
lambda _home: str(target_home),
|
|
)
|
|
|
|
unit = gateway_cli.generate_systemd_unit(system=True, run_as_user="service")
|
|
|
|
assert "Type=notify" in unit
|
|
assert "WatchdogSec=75s" in unit
|
|
|
|
|