mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
124 lines
3.8 KiB
Python
124 lines
3.8 KiB
Python
"""Tests for the Speech-to-Text category in `hermes tools` (tools_config).
|
|
|
|
Covers the STT provider picker rows, config writes (stt.provider /
|
|
use_gateway), the model picker catalog, config-only checklist exclusion,
|
|
and the faster_whisper post-setup readiness hook.
|
|
"""
|
|
|
|
import sys
|
|
import types
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parents[2]))
|
|
|
|
from hermes_cli.tools_config import ( # noqa: E402
|
|
_CONFIG_ONLY_TOOLSETS,
|
|
CONFIGURABLE_TOOLSETS,
|
|
STT_MODEL_CATALOG,
|
|
TOOL_CATEGORIES,
|
|
_checklist_toolset_keys,
|
|
_configure_stt_model,
|
|
_is_provider_active,
|
|
_write_provider_config,
|
|
apply_provider_selection,
|
|
)
|
|
|
|
|
|
def _stt_cat():
|
|
return TOOL_CATEGORIES["stt"]
|
|
|
|
|
|
def _stt_provider_named(name):
|
|
return next(p for p in _stt_cat()["providers"] if p["name"] == name)
|
|
|
|
|
|
class TestSttCategory:
|
|
def test_stt_category_exists(self):
|
|
cat = _stt_cat()
|
|
assert cat["name"] == "Speech-to-Text"
|
|
assert len(cat["providers"]) >= 5
|
|
|
|
|
|
|
|
|
|
def test_managed_row_shares_tts_coverage_category(self):
|
|
from hermes_cli.nous_subscription import MANAGED_FEATURE_COVERAGE_CATEGORY
|
|
|
|
managed = [p for p in _stt_cat()["providers"] if p.get("managed_nous_feature")]
|
|
assert managed, "expected a Nous Subscription row"
|
|
for p in managed:
|
|
assert p["managed_nous_feature"] == "stt"
|
|
assert MANAGED_FEATURE_COVERAGE_CATEGORY["stt"] == "openai-audio"
|
|
|
|
|
|
class TestConfigWrites:
|
|
def test_write_provider_config_sets_stt_provider(self):
|
|
config = {}
|
|
prov = _stt_provider_named("Groq")
|
|
_write_provider_config(prov, config, managed_feature=None)
|
|
assert config["stt"]["provider"] == "groq"
|
|
assert config["stt"]["use_gateway"] is False
|
|
|
|
|
|
def test_apply_provider_selection_stt(self):
|
|
config = {}
|
|
with patch(
|
|
"hermes_cli.tools_config.get_nous_subscription_features"
|
|
) as feats:
|
|
feats.return_value = MagicMock(
|
|
nous_auth_present=False, account_info=None
|
|
)
|
|
apply_provider_selection("stt", "OpenAI", config)
|
|
assert config["stt"]["provider"] == "openai"
|
|
|
|
|
|
class TestActiveDetection:
|
|
def test_active_matches_config(self):
|
|
config = {"stt": {"provider": "groq"}}
|
|
assert _is_provider_active(_stt_provider_named("Groq"), config)
|
|
assert not _is_provider_active(_stt_provider_named("OpenAI"), config)
|
|
|
|
def test_unset_provider_defaults_to_local(self):
|
|
assert _is_provider_active(_stt_provider_named("Local Whisper"), {})
|
|
|
|
|
|
class TestModelPicker:
|
|
|
|
def test_catalog_matches_runtime_model_sets(self):
|
|
from tools.transcription_tools import GROQ_MODELS, OPENAI_MODELS
|
|
|
|
assert set(STT_MODEL_CATALOG["openai"]) == OPENAI_MODELS
|
|
assert set(STT_MODEL_CATALOG["groq"]) == GROQ_MODELS
|
|
|
|
|
|
|
|
|
|
def test_configure_stt_model_defaults_to_current(self):
|
|
config = {"stt": {"openai": {"model": "gpt-transcribe"}}}
|
|
with patch(
|
|
"hermes_cli.tools_config._prompt_choice", return_value=0
|
|
) as pc:
|
|
_configure_stt_model("openai", config)
|
|
# default index should point at the currently configured model
|
|
args = pc.call_args[0]
|
|
assert args[2] == STT_MODEL_CATALOG["openai"].index("gpt-transcribe")
|
|
|
|
|
|
class TestConfigOnlyExclusion:
|
|
def test_stt_is_config_only(self):
|
|
assert "stt" in _CONFIG_ONLY_TOOLSETS
|
|
|
|
def test_stt_excluded_from_checklist_universe(self):
|
|
assert "stt" not in _checklist_toolset_keys("cli")
|
|
# sanity: tts (a real toolset) stays in
|
|
assert "tts" in _checklist_toolset_keys("cli")
|
|
|
|
|
|
class TestPostSetup:
|
|
def test_faster_whisper_in_post_setup_ready(self):
|
|
from hermes_cli.tools_config import _POST_SETUP_READY
|
|
|
|
assert "faster_whisper" in _POST_SETUP_READY
|