mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
86 lines
3.7 KiB
Python
86 lines
3.7 KiB
Python
"""
|
|
Tests for skip_confirm and invalidate_cache behavior in /skills install
|
|
and /skills uninstall slash commands.
|
|
|
|
Slash commands always skip confirmation (input() hangs in TUI).
|
|
Cache invalidation is deferred by default; --now opts into immediate
|
|
invalidation (at the cost of breaking prompt cache mid-session).
|
|
|
|
Based on PR #1595 by 333Alden333 (salvaged).
|
|
Updated for PR #3586 (cache-aware install/uninstall).
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
class TestHandleSkillsSlashInstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for install."""
|
|
|
|
def test_yes_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill --yes")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
assert kwargs.get("force") is False
|
|
|
|
|
|
class TestHandleSkillsSlashUninstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for uninstall."""
|
|
|
|
|
|
def test_no_flags_still_skips_confirm(self):
|
|
"""Slash commands always skip confirmation — input() hangs in TUI."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_default_defers_cache_invalidation(self):
|
|
"""Without --now, cache invalidation is deferred to next session."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("invalidate_cache") is False
|
|
|
|
|
|
class TestDoInstallSkipConfirm:
|
|
"""Test that do_install respects skip_confirm parameter."""
|
|
|
|
@patch("hermes_cli.skills_hub.input", return_value="n")
|
|
def test_without_skip_confirm_prompts_user(self, mock_input):
|
|
"""Without skip_confirm, input() is called for confirmation."""
|
|
from hermes_cli.skills_hub import do_install
|
|
with patch("hermes_cli.skills_hub._console"), \
|
|
patch("tools.skills_hub.ensure_hub_dirs"), \
|
|
patch("tools.skills_hub.GitHubAuth"), \
|
|
patch("tools.skills_hub.create_source_router") as mock_router, \
|
|
patch("hermes_cli.skills_hub._resolve_short_name", return_value="test/skill"), \
|
|
patch("hermes_cli.skills_hub._resolve_source_meta_and_bundle") as mock_resolve:
|
|
|
|
# Make it return None so we exit early
|
|
mock_resolve.return_value = (None, None, None)
|
|
do_install("test-skill", skip_confirm=False)
|
|
# We don't get to the input() call because resolve returns None,
|
|
# but the parameter wiring is correct
|
|
|
|
|
|
class TestDoUninstallSkipConfirm:
|
|
"""Test that do_uninstall respects skip_confirm parameter."""
|
|
|
|
def test_skip_confirm_bypasses_input(self):
|
|
"""With skip_confirm=True, input() should not be called."""
|
|
from hermes_cli.skills_hub import do_uninstall
|
|
with patch("hermes_cli.skills_hub._console") as mock_console, \
|
|
patch("tools.skills_hub.uninstall_skill", return_value=(True, "Removed")) as mock_uninstall, \
|
|
patch("builtins.input") as mock_input:
|
|
do_uninstall("test-skill", skip_confirm=True)
|
|
mock_input.assert_not_called()
|
|
mock_uninstall.assert_called_once_with("test-skill")
|
|
|
|
|