mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
58 lines
1.5 KiB
Python
58 lines
1.5 KiB
Python
"""
|
|
Tests for --yes / --force flag separation in `hermes skills install`.
|
|
|
|
--yes / -y → skip_confirm (bypass interactive prompt, needed in TUI mode)
|
|
--force → force (install despite blocked scan verdict)
|
|
|
|
Based on PR #1595 by 333Alden333 (salvaged).
|
|
"""
|
|
|
|
import sys
|
|
|
|
|
|
def test_cli_skills_install_yes_sets_skip_confirm(monkeypatch):
|
|
"""--yes should set skip_confirm=True but NOT force."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["identifier"] = args.identifier
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "official/email/agentmail", "--yes"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["identifier"] == "official/email/agentmail"
|
|
assert captured["yes"] is True
|
|
assert captured["force"] is False
|
|
|
|
|
|
def test_cli_skills_install_no_flags(monkeypatch):
|
|
"""Without flags, both force and yes should be False."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "test/skill"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["force"] is False
|
|
assert captured["yes"] is False
|