mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
104 lines
3 KiB
Python
104 lines
3 KiB
Python
"""Tests for `hermes secrets bitwarden token` / `hermes secrets onepassword token`.
|
|
|
|
The rotation command must: verify the candidate token BEFORE persisting,
|
|
never touch .env on a rejected token, store + clear caches on success,
|
|
and fail cleanly without a TTY.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import onepassword_secrets_cli as op_cli
|
|
from hermes_cli import secrets_cli as bw_cli
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Bitwarden
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _bw_args(**overrides):
|
|
return argparse.Namespace(
|
|
access_token=overrides.get("access_token", ""),
|
|
no_verify=overrides.get("no_verify", False),
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def bw_env(monkeypatch, tmp_path):
|
|
saved = {}
|
|
monkeypatch.setattr(bw_cli, "load_config", lambda: {
|
|
"secrets": {"bitwarden": {
|
|
"enabled": True,
|
|
"access_token_env": "BWS_ACCESS_TOKEN",
|
|
"project_id": "proj-1",
|
|
"server_url": "",
|
|
}},
|
|
})
|
|
monkeypatch.setattr(
|
|
bw_cli, "save_env_value",
|
|
lambda name, value: saved.__setitem__(name, value),
|
|
)
|
|
monkeypatch.setattr(bw_cli, "get_env_path", lambda: tmp_path / ".env")
|
|
monkeypatch.setattr(
|
|
bw_cli.bw, "find_bws",
|
|
lambda install_if_missing=True: Path("/fake/bws"),
|
|
)
|
|
return saved
|
|
|
|
|
|
|
|
|
|
def test_bw_token_no_verify_skips_probe(bw_env, monkeypatch):
|
|
probe = mock.Mock()
|
|
monkeypatch.setattr(bw_cli, "_list_projects", probe)
|
|
monkeypatch.setattr(bw_cli.bw, "clear_caches", lambda *a, **kw: None)
|
|
rc = bw_cli.cmd_token(_bw_args(access_token="0.x", no_verify=True))
|
|
assert rc == 0
|
|
probe.assert_not_called()
|
|
assert bw_env == {"BWS_ACCESS_TOKEN": "0.x"}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# 1Password
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _op_args(**overrides):
|
|
return argparse.Namespace(
|
|
token=overrides.get("token", ""),
|
|
no_verify=overrides.get("no_verify", False),
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def op_env(monkeypatch, tmp_path):
|
|
saved = {}
|
|
monkeypatch.setattr(op_cli, "load_config", lambda: {
|
|
"secrets": {"onepassword": {
|
|
"enabled": True,
|
|
"service_account_token_env": "OP_SERVICE_ACCOUNT_TOKEN",
|
|
}},
|
|
})
|
|
monkeypatch.setattr(
|
|
op_cli, "save_env_value",
|
|
lambda name, value: saved.__setitem__(name, value),
|
|
)
|
|
monkeypatch.setattr(op_cli, "get_env_path", lambda: tmp_path / ".env")
|
|
monkeypatch.setattr(
|
|
op_cli.op_src, "find_op", lambda binary_path="": Path("/fake/op")
|
|
)
|
|
return saved
|
|
|
|
|
|
|
|
|
|
def test_op_token_non_tty_requires_flag(op_env, monkeypatch):
|
|
monkeypatch.setattr("sys.stdin.isatty", lambda: False)
|
|
rc = op_cli.cmd_token(_op_args())
|
|
assert rc == 1
|
|
assert op_env == {}
|