mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
81 lines
3.1 KiB
Python
81 lines
3.1 KiB
Python
"""Regression tests for hermes secrets bitwarden setup non-TTY guard.
|
|
|
|
Issue #40274: cmd_setup() crashes with EOFError when stdin is not a TTY
|
|
because getpass.getpass() and console.input() require an interactive terminal.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
class TestCmdSetupNonTtyGuard:
|
|
"""cmd_setup should fail early with a clear error in non-TTY environments."""
|
|
|
|
@staticmethod
|
|
def _make_args(**overrides):
|
|
ns = argparse.Namespace(
|
|
access_token=overrides.get("access_token", ""),
|
|
server_url=overrides.get("server_url", ""),
|
|
project_id=overrides.get("project_id", ""),
|
|
)
|
|
return ns
|
|
|
|
|
|
def test_missing_access_token_only(self, monkeypatch, capsys):
|
|
"""Non-TTY with server-url and project-id but no token → reports --access-token."""
|
|
monkeypatch.setattr("sys.stdin.isatty", lambda: False)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.secrets_cli.bw.find_bws", lambda install_if_missing=False: "/usr/bin/bws"
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.secrets_cli._bws_version", lambda _: "2.0.0"
|
|
)
|
|
|
|
from hermes_cli.secrets_cli import cmd_setup
|
|
|
|
result = cmd_setup(self._make_args(
|
|
server_url="https://vault.bitwarden.com",
|
|
project_id="aaaa-bbbb",
|
|
))
|
|
assert result == 1
|
|
captured = capsys.readouterr()
|
|
# The "Missing:" line should list --access-token only
|
|
assert "Missing:" in captured.out
|
|
assert "--access-token" in captured.out
|
|
# The usage example contains --server-url and --project-id, so check
|
|
# the missing line specifically: it should NOT list them as missing
|
|
missing_line = [l for l in captured.out.split("\n") if "Missing:" in l][0]
|
|
assert "--access-token" in missing_line
|
|
assert "--server-url" not in missing_line
|
|
assert "--project-id" not in missing_line
|
|
|
|
def test_missing_server_url_with_env_var_passes(self, monkeypatch):
|
|
"""Non-TTY with BWS_SERVER_URL env set → server-url not required."""
|
|
monkeypatch.setattr("sys.stdin.isatty", lambda: False)
|
|
monkeypatch.setenv("BWS_SERVER_URL", "https://vault.bitwarden.com")
|
|
monkeypatch.setattr(
|
|
"hermes_cli.secrets_cli.bw.find_bws", lambda install_if_missing=False: "/usr/bin/bws"
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.secrets_cli._bws_version", lambda _: "2.0.0"
|
|
)
|
|
monkeypatch.setattr("hermes_cli.secrets_cli.load_config", lambda: {})
|
|
monkeypatch.setattr("hermes_cli.secrets_cli.save_env_value", lambda *a: None)
|
|
monkeypatch.setattr("hermes_cli.secrets_cli.get_env_path", lambda: "/tmp/.env")
|
|
monkeypatch.setattr(
|
|
"hermes_cli.secrets_cli.bw.fetch_bitwarden_secrets",
|
|
lambda **kw: ({"KEY": "val"}, []),
|
|
)
|
|
|
|
from hermes_cli.secrets_cli import cmd_setup
|
|
|
|
result = cmd_setup(self._make_args(
|
|
access_token="0.valid-token",
|
|
project_id="aaaa-bbbb",
|
|
))
|
|
assert result == 0
|
|
|
|
|