mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
56 lines
1.3 KiB
Python
56 lines
1.3 KiB
Python
import pytest
|
|
|
|
from hermes_cli.secret_prompt import _collect_masked_input, masked_secret_prompt
|
|
|
|
|
|
def _run_collect(chars: str):
|
|
output: list[str] = []
|
|
iterator = iter(chars)
|
|
|
|
def read_char() -> str:
|
|
return next(iterator, "")
|
|
|
|
def write(text: str) -> None:
|
|
output.append(text)
|
|
|
|
value = _collect_masked_input(
|
|
read_char,
|
|
write,
|
|
"API key: ",
|
|
)
|
|
return value, "".join(output)
|
|
|
|
|
|
def test_collect_masked_input_shows_feedback_without_echoing_secret():
|
|
value, output = _run_collect("secret\n")
|
|
|
|
assert value == "secret"
|
|
assert output == "API key: ******\r\n"
|
|
assert "secret" not in output
|
|
|
|
|
|
|
|
|
|
def test_collect_masked_input_raises_keyboard_interrupt():
|
|
output: list[str] = []
|
|
|
|
with pytest.raises(KeyboardInterrupt):
|
|
_collect_masked_input(
|
|
lambda: "\x03",
|
|
output.append,
|
|
"API key: ",
|
|
)
|
|
|
|
assert "".join(output) == "API key: \r\n"
|
|
|
|
|
|
def test_masked_secret_prompt_falls_back_to_getpass_for_non_tty(monkeypatch):
|
|
class NonTty:
|
|
def isatty(self):
|
|
return False
|
|
|
|
monkeypatch.setattr("sys.stdin", NonTty())
|
|
monkeypatch.setattr("sys.stdout", NonTty())
|
|
monkeypatch.setattr("getpass.getpass", lambda prompt: f"value from {prompt}")
|
|
|
|
assert masked_secret_prompt("API key: ") == "value from API key: "
|