mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
"""Tests for the Remote-Spending gate denial contract (NAS PR #481).
|
|
|
|
Behavior contracts: the HTTP→exception mapping in
|
|
``hermes_cli.nous_billing._raise_for_error`` and the
|
|
``tui_gateway.server._serialize_billing_error`` envelope the TUI branches on.
|
|
These assert the wire contract (CF-4) — error code, actor, recovery, retry —
|
|
not specific copy.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.nous_billing import (
|
|
BillingError,
|
|
BillingRateLimited,
|
|
BillingRemoteSpendingRevoked,
|
|
BillingScopeRequired,
|
|
BillingSessionRevoked,
|
|
_raise_for_error,
|
|
)
|
|
|
|
|
|
def _raise(status, payload, headers=None):
|
|
"""Run _raise_for_error and return the exception it raises."""
|
|
with pytest.raises(BillingError) as ei:
|
|
_raise_for_error(status, payload, headers)
|
|
return ei.value
|
|
|
|
|
|
# ── exception mapping (hermes_cli.nous_billing) ──────────────────────
|
|
|
|
|
|
def test_403_remote_spending_revoked_maps_to_typed_exc_with_actor():
|
|
exc = _raise(403, {"error": "remote_spending_revoked", "recovery": "reconnect", "actor": "admin"})
|
|
assert isinstance(exc, BillingRemoteSpendingRevoked)
|
|
assert exc.actor == "admin"
|
|
assert exc.recovery == "reconnect"
|
|
|
|
|
|
def test_401_session_revoked_is_distinct_from_plain_401():
|
|
revoked = _raise(401, {"error": "session_revoked", "recovery": "login"})
|
|
assert isinstance(revoked, BillingSessionRevoked)
|
|
assert revoked.recovery == "login"
|
|
|
|
plain = _raise(401, {"error": "invalid_token"})
|
|
assert not isinstance(plain, BillingSessionRevoked)
|
|
|
|
|
|
def test_503_is_rate_limited_not_revoked_and_carries_retry_after():
|
|
exc = _raise(503, {"error": "temporarily_unavailable"}, {"Retry-After": "30"})
|
|
assert isinstance(exc, BillingRateLimited)
|
|
assert not isinstance(exc, BillingRemoteSpendingRevoked)
|
|
assert exc.retry_after == 30
|
|
|
|
|
|
|
|
|
|
def test_409_idempotency_conflict_passes_through():
|
|
exc = _raise(409, {"error": "idempotency_conflict", "message": "same key, different amount"})
|
|
assert exc.error == "idempotency_conflict"
|
|
|
|
|
|
# ── envelope serialization (tui_gateway.server) ──────────────────────
|
|
|
|
|
|
def _serialize(status, payload, headers=None):
|
|
import tui_gateway.server as srv
|
|
|
|
return srv._serialize_billing_error(_raise(status, payload, headers))
|
|
|
|
|
|
|
|
|