mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
93 lines
2.8 KiB
Python
93 lines
2.8 KiB
Python
"""Tests for the profile.yaml metadata layer (description + description_auto)
|
|
and the profile_describer LLM module.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json as jsonlib
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import profiles as profiles_mod
|
|
from hermes_cli import profile_describer as describer
|
|
|
|
|
|
@pytest.fixture
|
|
def profile_env(tmp_path, monkeypatch):
|
|
"""Set up an isolated HERMES_HOME with a default profile dir."""
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
return home
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# profile_describer module
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _fake_aux_response(content: str):
|
|
resp = MagicMock()
|
|
resp.choices = [MagicMock()]
|
|
resp.choices[0].message.content = content
|
|
return resp
|
|
|
|
|
|
def _patch_aux_client(content: str):
|
|
# describe_profile now routes through call_llm (#35566) — mock it at the
|
|
# source module.
|
|
return patch(
|
|
"agent.auxiliary_client.call_llm",
|
|
return_value=_fake_aux_response(content),
|
|
)
|
|
|
|
|
|
def test_describer_writes_description_with_auto_true(profile_env, monkeypatch):
|
|
# Pretend "myprof" is a registered profile pointing at profile_env.
|
|
monkeypatch.setattr(
|
|
profiles_mod, "profile_exists", lambda n: n == "myprof",
|
|
)
|
|
monkeypatch.setattr(
|
|
profiles_mod, "normalize_profile_name", lambda n: n,
|
|
)
|
|
monkeypatch.setattr(
|
|
profiles_mod, "get_profile_dir", lambda n: profile_env,
|
|
)
|
|
|
|
payload = jsonlib.dumps({"description": "writes Python codebases"})
|
|
with _patch_aux_client(payload), patch(
|
|
"agent.auxiliary_client.get_auxiliary_extra_body", return_value={}
|
|
):
|
|
outcome = describer.describe_profile("myprof")
|
|
|
|
assert outcome.ok, outcome.reason
|
|
assert outcome.description == "writes Python codebases"
|
|
meta = profiles_mod.read_profile_meta(profile_env)
|
|
assert meta["description"] == "writes Python codebases"
|
|
assert meta["description_auto"] is True
|
|
|
|
|
|
def test_describer_refuses_to_overwrite_user_authored(profile_env, monkeypatch):
|
|
profiles_mod.write_profile_meta(
|
|
profile_env, description="curated", description_auto=False,
|
|
)
|
|
monkeypatch.setattr(profiles_mod, "profile_exists", lambda n: n == "myprof")
|
|
monkeypatch.setattr(profiles_mod, "normalize_profile_name", lambda n: n)
|
|
monkeypatch.setattr(profiles_mod, "get_profile_dir", lambda n: profile_env)
|
|
|
|
outcome = describer.describe_profile("myprof")
|
|
assert outcome.ok is False
|
|
assert "already has a user-authored description" in outcome.reason
|
|
# Description unchanged
|
|
assert profiles_mod.read_profile_meta(profile_env)["description"] == "curated"
|
|
|
|
|