mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
2.4 KiB
Python
72 lines
2.4 KiB
Python
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_code_scoped_stamp_wins_over_home_stamp(tmp_path):
|
|
"""The stamp next to the running code is authoritative over $HERMES_HOME.
|
|
|
|
Models a host git install whose $HERMES_HOME is shared with (and stamped
|
|
'docker' by) a co-located container. The code-scoped stamp must win so the
|
|
host install is correctly identified as 'git' and 'hermes update' works.
|
|
"""
|
|
code = tmp_path / "code"
|
|
home = tmp_path / "home"
|
|
code.mkdir()
|
|
home.mkdir()
|
|
(code / ".install_method").write_text("git\n")
|
|
(home / ".install_method").write_text("docker\n") # container contamination
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=home):
|
|
from hermes_cli.config import detect_install_method
|
|
assert detect_install_method(project_root=code) == "git"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_stamp_install_method_writes_code_scoped(tmp_path):
|
|
"""stamp_install_method writes next to the code, not into $HERMES_HOME."""
|
|
code = tmp_path / "code"
|
|
home = tmp_path / "home"
|
|
code.mkdir()
|
|
home.mkdir()
|
|
with patch("hermes_cli.config.get_hermes_home", return_value=home):
|
|
from hermes_cli.config import stamp_install_method
|
|
stamp_install_method("git", project_root=code)
|
|
assert (code / ".install_method").read_text().strip() == "git"
|
|
assert not (home / ".install_method").exists()
|
|
|
|
|
|
def test_container_without_stamp_is_not_docker(tmp_path):
|
|
"""An unstamped install in a generic container must NOT be flagged as docker.
|
|
|
|
Regression for issue #34397. The two supported installs both stamp
|
|
``.install_method`` (the curl installer -> ``git``, covered by
|
|
``test_stamp_file_takes_precedence``; the published image -> ``docker``),
|
|
so neither hits this path. An unsupported manual install dropped into a
|
|
container has no stamp and was wrongly classified as the published Docker
|
|
image, so ``hermes update`` refused to run. With a ``.git`` checkout it
|
|
must resolve to ``git``.
|
|
"""
|
|
(tmp_path / ".git").mkdir()
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path), \
|
|
patch("hermes_constants.is_container", return_value=True):
|
|
from hermes_cli.config import detect_install_method
|
|
assert detect_install_method(project_root=tmp_path) == "git"
|
|
|
|
|
|
|
|
|
|
|
|
|