mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
45 lines
1.3 KiB
Python
45 lines
1.3 KiB
Python
"""Tests for the Nous-Hermes-3/4 non-agentic warning detector.
|
|
|
|
Prior to this check, the warning fired on any model whose name contained
|
|
``"hermes"`` anywhere (case-insensitive). That false-positived on unrelated
|
|
local Modelfiles such as ``hermes-brain:qwen3-14b-ctx16k`` — a tool-capable
|
|
Qwen3 wrapper that happens to live under the "hermes" tag namespace.
|
|
|
|
``is_nous_hermes_non_agentic`` should only match the actual Nous Research
|
|
Hermes-3 / Hermes-4 chat family.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.model_switch import (
|
|
_HERMES_MODEL_WARNING,
|
|
_check_hermes_model_warning,
|
|
is_nous_hermes_non_agentic,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model_name",
|
|
[
|
|
"NousResearch/Hermes-3-Llama-3.1-70B",
|
|
"NousResearch/Hermes-3-Llama-3.1-405B",
|
|
"hermes-3",
|
|
"Hermes-3",
|
|
"hermes-4",
|
|
"hermes-4-405b",
|
|
"hermes_4_70b",
|
|
"openrouter/hermes3:70b",
|
|
"openrouter/nousresearch/hermes-4-405b",
|
|
"NousResearch/Hermes3",
|
|
"hermes-3.1",
|
|
],
|
|
)
|
|
def test_matches_real_nous_hermes_chat_models(model_name: str) -> None:
|
|
assert is_nous_hermes_non_agentic(model_name), (
|
|
f"expected {model_name!r} to be flagged as Nous Hermes 3/4"
|
|
)
|
|
assert _check_hermes_model_warning(model_name) == _HERMES_MODEL_WARNING
|
|
|
|
|