mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
62 lines
2.2 KiB
Python
62 lines
2.2 KiB
Python
"""Tests for the approvals.mcp_reload_confirm config gate.
|
|
|
|
When the user runs /reload-mcp, the MCP tool set is rebuilt which
|
|
invalidates the provider prompt cache for the active session. That's
|
|
expensive on long-context / high-reasoning models. The config gate
|
|
adds a three-option confirmation (Approve Once / Always Approve /
|
|
Cancel); "Always Approve" flips this key to false so subsequent reloads
|
|
run silently.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
from hermes_cli.config import DEFAULT_CONFIG
|
|
|
|
|
|
class TestMcpReloadConfirmDefault:
|
|
def test_default_config_has_the_key(self):
|
|
approvals = DEFAULT_CONFIG.get("approvals")
|
|
assert isinstance(approvals, dict)
|
|
assert "mcp_reload_confirm" in approvals
|
|
|
|
def test_default_is_true(self):
|
|
# New installs confirm by default — this is the safe behavior.
|
|
assert DEFAULT_CONFIG["approvals"]["mcp_reload_confirm"] is True
|
|
|
|
def test_shape_matches_other_approval_keys(self):
|
|
# Same flat dict level as `mode` / `timeout` / `cron_mode`.
|
|
approvals = DEFAULT_CONFIG["approvals"]
|
|
assert isinstance(approvals.get("mode"), str)
|
|
assert isinstance(approvals.get("timeout"), int)
|
|
assert isinstance(approvals.get("cron_mode"), str)
|
|
assert isinstance(approvals.get("mcp_reload_confirm"), bool)
|
|
|
|
|
|
class TestUserConfigMerge:
|
|
"""If a user has a pre-existing config without this key, load_config
|
|
should fill it in from DEFAULT_CONFIG (deep merge preserves keys the
|
|
user didn't override).
|
|
"""
|
|
|
|
def test_existing_user_config_without_key_gets_default(self, tmp_path, monkeypatch):
|
|
import yaml
|
|
|
|
# Simulate a legacy user config without the new key.
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
cfg_path = home / "config.yaml"
|
|
legacy = {
|
|
"approvals": {"mode": "manual", "timeout": 60, "cron_mode": "deny"},
|
|
}
|
|
cfg_path.write_text(yaml.safe_dump(legacy))
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
# Force a fresh reimport of config.py so the HERMES_HOME is honored.
|
|
import importlib
|
|
import hermes_cli.config as cfg_mod
|
|
importlib.reload(cfg_mod)
|
|
|
|
cfg = cfg_mod.load_config()
|
|
assert cfg["approvals"]["mcp_reload_confirm"] is True
|
|
|