mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
81 lines
2.4 KiB
Python
81 lines
2.4 KiB
Python
"""Tests for kb.specify_triage_task — the DB-layer atomic promotion
|
|
from the triage column to todo. LLM-free by design."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban_db as kb
|
|
|
|
|
|
@pytest.fixture
|
|
def kanban_home(tmp_path, monkeypatch):
|
|
"""Isolated HERMES_HOME with an empty kanban DB."""
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
kb.init_db()
|
|
return home
|
|
|
|
|
|
def _create_triage(conn, title="rough idea", body=None, assignee=None):
|
|
return kb.create_task(
|
|
conn,
|
|
title=title,
|
|
body=body,
|
|
assignee=assignee,
|
|
triage=True,
|
|
)
|
|
|
|
|
|
def test_specify_promotes_triage_to_todo(kanban_home):
|
|
with kb.connect() as conn:
|
|
tid = _create_triage(conn, title="rough idea")
|
|
assert kb.get_task(conn, tid).status == "triage"
|
|
with kb.connect() as conn:
|
|
ok = kb.specify_triage_task(
|
|
conn,
|
|
tid,
|
|
title="Refined: rough idea",
|
|
body="**Goal**\nDo the thing.",
|
|
author="specifier-bot",
|
|
)
|
|
assert ok is True
|
|
with kb.connect() as conn:
|
|
task = kb.get_task(conn, tid)
|
|
# No parents → recompute_ready should have flipped it past todo to ready.
|
|
assert task.status == "ready"
|
|
assert task.title == "Refined: rough idea"
|
|
assert "**Goal**" in (task.body or "")
|
|
|
|
|
|
def test_specify_rejects_blank_title(kanban_home):
|
|
with kb.connect() as conn:
|
|
tid = _create_triage(conn, title="rough")
|
|
with kb.connect() as conn, pytest.raises(ValueError):
|
|
kb.specify_triage_task(conn, tid, title=" ", body="ok")
|
|
|
|
|
|
def test_specify_records_audit_comment_only_when_author_given(kanban_home):
|
|
# With author → comment added.
|
|
with kb.connect() as conn:
|
|
tid1 = _create_triage(conn, title="a")
|
|
kb.specify_triage_task(
|
|
conn, tid1, title="A-spec", body="b", author="ace"
|
|
)
|
|
comments1 = kb.list_comments(conn, tid1)
|
|
assert len(comments1) == 1
|
|
assert "Specified" in comments1[0].body
|
|
assert comments1[0].author == "ace"
|
|
|
|
# Without author → no comment (silent).
|
|
with kb.connect() as conn:
|
|
tid2 = _create_triage(conn, title="b")
|
|
kb.specify_triage_task(conn, tid2, title="B-spec", body="b")
|
|
comments2 = kb.list_comments(conn, tid2)
|
|
assert comments2 == []
|
|
|
|
|