mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
90 lines
2.7 KiB
Python
90 lines
2.7 KiB
Python
"""Tests for kanban lifecycle plugin hooks.
|
|
|
|
Verifies that claim/complete/block transitions fire the
|
|
kanban_task_claimed / kanban_task_completed / kanban_task_blocked plugin
|
|
hooks AFTER the board DB change is committed, with the documented kwargs,
|
|
and that a misbehaving hook callback never breaks the transition.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban_db as kb
|
|
from hermes_cli.plugins import VALID_HOOKS, get_plugin_manager
|
|
|
|
|
|
@pytest.fixture
|
|
def kanban_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
kb.init_db()
|
|
return home
|
|
|
|
|
|
@pytest.fixture
|
|
def captured_hooks(monkeypatch):
|
|
"""Register capturing callbacks for the three kanban lifecycle hooks.
|
|
|
|
Patches the plugin manager's _hooks dict directly (the same registry
|
|
invoke_hook reads) and restores it afterward.
|
|
"""
|
|
mgr = get_plugin_manager()
|
|
events: list[tuple[str, dict]] = []
|
|
saved = {k: list(v) for k, v in mgr._hooks.items()}
|
|
for hook in ("kanban_task_claimed", "kanban_task_completed", "kanban_task_blocked"):
|
|
mgr._hooks.setdefault(hook, []).append(
|
|
lambda _h=hook, **kw: events.append((_h, kw))
|
|
)
|
|
try:
|
|
yield events
|
|
finally:
|
|
mgr._hooks = saved
|
|
|
|
|
|
|
|
|
|
def test_claim_fires_hook(kanban_home, captured_hooks):
|
|
conn = kb.connect()
|
|
try:
|
|
tid = kb.create_task(conn, title="t", assignee="worker")
|
|
claimed = kb.claim_task(conn, tid)
|
|
assert claimed is not None
|
|
finally:
|
|
conn.close()
|
|
fired = [e for e in captured_hooks if e[0] == "kanban_task_claimed"]
|
|
assert len(fired) == 1
|
|
kw = fired[0][1]
|
|
assert kw["task_id"] == tid
|
|
assert kw["assignee"] == "worker"
|
|
assert "profile_name" in kw
|
|
assert kw["run_id"] is not None
|
|
|
|
|
|
|
|
|
|
def test_misbehaving_hook_does_not_break_transition(kanban_home, monkeypatch):
|
|
"""A hook callback that raises must not break the board transition."""
|
|
mgr = get_plugin_manager()
|
|
saved = {k: list(v) for k, v in mgr._hooks.items()}
|
|
|
|
def _boom(**kw):
|
|
raise RuntimeError("plugin exploded")
|
|
|
|
mgr._hooks.setdefault("kanban_task_completed", []).append(_boom)
|
|
try:
|
|
conn = kb.connect()
|
|
try:
|
|
tid = kb.create_task(conn, title="t", assignee="worker")
|
|
kb.claim_task(conn, tid)
|
|
# Despite the raising hook, completion succeeds and persists.
|
|
assert kb.complete_task(conn, tid, summary="ok") is True
|
|
assert kb.get_task(conn, tid).status == "done"
|
|
finally:
|
|
conn.close()
|
|
finally:
|
|
mgr._hooks = saved
|