mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
92 lines
2.6 KiB
Python
92 lines
2.6 KiB
Python
"""Tests for kb.decompose_triage_task — the DB-layer atomic fan-out
|
|
from the triage column. LLM-free by design.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban_db as kb
|
|
|
|
|
|
@pytest.fixture
|
|
def kanban_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
kb.init_db()
|
|
return home
|
|
|
|
|
|
def _create_triage(conn, title="rough idea", body=None, assignee=None, tenant=None):
|
|
return kb.create_task(
|
|
conn,
|
|
title=title,
|
|
body=body,
|
|
assignee=assignee,
|
|
tenant=tenant,
|
|
triage=True,
|
|
)
|
|
|
|
|
|
def test_decompose_creates_children_and_promotes_root(kanban_home):
|
|
with kb.connect() as conn:
|
|
tid = _create_triage(conn, title="ship a feature")
|
|
assert kb.get_task(conn, tid).status == "triage"
|
|
|
|
children = [
|
|
{"title": "research", "body": "look at prior art", "assignee": "researcher", "parents": []},
|
|
{"title": "build it", "body": "write code", "assignee": "engineer", "parents": [0]},
|
|
]
|
|
with kb.connect() as conn:
|
|
child_ids = kb.decompose_triage_task(
|
|
conn,
|
|
tid,
|
|
root_assignee="orchestrator",
|
|
children=children,
|
|
author="decomposer",
|
|
)
|
|
assert child_ids is not None
|
|
assert len(child_ids) == 2
|
|
|
|
with kb.connect() as conn:
|
|
root = kb.get_task(conn, tid)
|
|
c0 = kb.get_task(conn, child_ids[0])
|
|
c1 = kb.get_task(conn, child_ids[1])
|
|
|
|
# Root flipped to todo with orchestrator assignee, gated by children.
|
|
assert root.status == "todo"
|
|
assert root.assignee == "orchestrator"
|
|
# First child has no internal parents → ready on recompute_ready.
|
|
assert c0.status == "ready"
|
|
assert c0.assignee == "researcher"
|
|
# Second child has parents=[0] → stays in todo until c0 completes.
|
|
assert c1.status == "todo"
|
|
assert c1.assignee == "engineer"
|
|
|
|
|
|
def test_decompose_records_audit_comment_and_event(kanban_home):
|
|
with kb.connect() as conn:
|
|
tid = _create_triage(conn)
|
|
child_ids = kb.decompose_triage_task(
|
|
conn,
|
|
tid,
|
|
root_assignee="orch",
|
|
children=[{"title": "task A", "assignee": "researcher"}],
|
|
author="alice",
|
|
)
|
|
assert child_ids is not None
|
|
|
|
with kb.connect() as conn:
|
|
comments = kb.list_comments(conn, tid)
|
|
events = kb.list_events(conn, tid)
|
|
|
|
assert any("Decomposed into" in (c.body or "") for c in comments)
|
|
assert any(ev.kind == "decomposed" for ev in events)
|
|
|
|
|
|
|
|
|