mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
65 lines
1.9 KiB
Python
65 lines
1.9 KiB
Python
"""Tests for ``kanban_db.count_notify_subs`` — the read-only subscription probe.
|
|
|
|
The gateway notifier uses it to skip boards with zero subscriptions BEFORE
|
|
any writable ``connect()``: the probe must never create the DB file, never
|
|
run schema init/migration, and never write — that first-open cost on every
|
|
tick is exactly what the zero-sub early exit avoids. It must also never
|
|
UNDER-count: rows sitting in a not-yet-checkpointed WAL still count, or the
|
|
notifier would skip a board that has a live subscription.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban_db as kb
|
|
|
|
|
|
@pytest.fixture
|
|
def kanban_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_KANBAN_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
return home
|
|
|
|
|
|
def test_missing_db_counts_zero_and_creates_nothing(kanban_home):
|
|
db_path = kb.kanban_db_path(board="default")
|
|
assert not db_path.exists()
|
|
assert kb.count_notify_subs(board="default") == 0
|
|
assert not db_path.exists(), "read-only probe must not create the DB"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_legacy_db_without_subs_table_counts_zero_and_stays_unmigrated(tmp_path):
|
|
legacy = tmp_path / "legacy.db"
|
|
conn = sqlite3.connect(legacy)
|
|
try:
|
|
conn.execute("CREATE TABLE something_else (id INTEGER)")
|
|
conn.commit()
|
|
finally:
|
|
conn.close()
|
|
assert kb.count_notify_subs(db_path=legacy) == 0
|
|
# The probe must not have run schema init on the foreign/legacy DB.
|
|
conn = sqlite3.connect(legacy)
|
|
try:
|
|
tables = {
|
|
r[0] for r in conn.execute(
|
|
"SELECT name FROM sqlite_master WHERE type='table'"
|
|
)
|
|
}
|
|
finally:
|
|
conn.close()
|
|
assert "kanban_notify_subs" not in tables, (
|
|
"read-only probe must never create schema"
|
|
)
|
|
|
|
|