mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
22 lines
960 B
Python
22 lines
960 B
Python
from unittest.mock import patch
|
|
|
|
|
|
def test_service_path_skips_nonexistent_node_modules(tmp_path):
|
|
"""Service PATH should not include node_modules/.bin if it doesn't exist."""
|
|
from hermes_cli.gateway import _build_service_path_dirs
|
|
with patch("hermes_cli.gateway.get_hermes_home", return_value=tmp_path / ".hermes"):
|
|
dirs = _build_service_path_dirs(project_root=tmp_path)
|
|
node_modules_bin = str(tmp_path / "node_modules" / ".bin")
|
|
assert node_modules_bin not in dirs
|
|
|
|
|
|
def test_service_path_includes_node_modules_when_present(tmp_path):
|
|
"""Service PATH should include node_modules/.bin when it exists."""
|
|
nm_bin = tmp_path / "node_modules" / ".bin"
|
|
nm_bin.mkdir(parents=True)
|
|
from hermes_cli.gateway import _build_service_path_dirs
|
|
with patch("hermes_cli.gateway.get_hermes_home", return_value=tmp_path / ".hermes"):
|
|
dirs = _build_service_path_dirs(project_root=tmp_path)
|
|
assert str(nm_bin) in dirs
|
|
|
|
|