mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
77 lines
2.6 KiB
Python
77 lines
2.6 KiB
Python
"""Regression tests for CLI gateway run exit behavior.
|
|
|
|
``hermes gateway run`` enters through hermes_cli.gateway, not gateway.run.main().
|
|
After graceful teardown it must use the same hard-exit backstop as gateway.run.main()
|
|
so Python finalization does not wait on non-daemon worker threads (for example
|
|
in-flight cron ThreadPoolExecutor jobs) and delay service-managed restarts.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import types
|
|
|
|
import pytest
|
|
|
|
|
|
class _HardExitObserved(BaseException):
|
|
def __init__(self, code: int):
|
|
super().__init__(code)
|
|
self.code = code
|
|
|
|
|
|
def _prepare(monkeypatch):
|
|
import hermes_cli.gateway as gateway_cli
|
|
import gateway.run as gateway_run
|
|
|
|
monkeypatch.setattr(gateway_cli, "_guard_official_docker_root_gateway", lambda: None)
|
|
monkeypatch.setattr(gateway_cli, "_guard_named_profile_under_multiplexer", lambda force=False: None)
|
|
monkeypatch.setattr(gateway_cli, "_guard_supervised_gateway_conflict", lambda force=False: None)
|
|
monkeypatch.setattr(gateway_cli, "_guard_existing_gateway_process_conflict", lambda replace=False: None)
|
|
monkeypatch.setattr(gateway_cli, "supports_systemd_services", lambda: False)
|
|
monkeypatch.setattr(gateway_cli.sys, "stdin", types.SimpleNamespace(isatty=lambda: False))
|
|
monkeypatch.setenv("HERMES_GATEWAY_EXIT_DIAG", "0")
|
|
|
|
async def _start_gateway(*args, **kwargs): # pragma: no cover - never awaited by fake run
|
|
return True
|
|
|
|
def _hard_exit(code: int) -> None:
|
|
raise _HardExitObserved(code)
|
|
|
|
monkeypatch.setattr(gateway_run, "start_gateway", _start_gateway)
|
|
monkeypatch.setattr(gateway_run, "_exit_after_graceful_shutdown", _hard_exit)
|
|
return gateway_cli
|
|
|
|
|
|
def test_run_gateway_hard_exits_after_clean_return(monkeypatch):
|
|
gateway_cli = _prepare(monkeypatch)
|
|
|
|
def _fake_run(coro):
|
|
coro.close()
|
|
return True
|
|
|
|
monkeypatch.setattr(gateway_cli.asyncio, "run", _fake_run)
|
|
|
|
with pytest.raises(_HardExitObserved) as excinfo:
|
|
gateway_cli.run_gateway()
|
|
|
|
assert excinfo.value.code == 0
|
|
|
|
|
|
def test_run_gateway_hard_exits_after_keyboard_interrupt(monkeypatch):
|
|
"""KeyboardInterrupt (console Ctrl+C) must also hard-exit, not return.
|
|
|
|
A bare ``return`` would let Python finalization join non-daemon worker
|
|
threads, the same wedge this backstop prevents on the other exit paths.
|
|
"""
|
|
gateway_cli = _prepare(monkeypatch)
|
|
|
|
def _fake_run(coro):
|
|
coro.close()
|
|
raise KeyboardInterrupt()
|
|
|
|
monkeypatch.setattr(gateway_cli.asyncio, "run", _fake_run)
|
|
|
|
with pytest.raises(_HardExitObserved) as excinfo:
|
|
gateway_cli.run_gateway()
|
|
|
|
assert excinfo.value.code == 0
|