mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
116 lines
3.6 KiB
Python
116 lines
3.6 KiB
Python
"""Regression tests for hermes_cli._ensure_utf8().
|
|
|
|
Covers the crash class where the setup wizard (and other banner-printing
|
|
commands) emit box-drawing characters and the ⚕ glyph, which raise
|
|
UnicodeEncodeError when stdout/stderr are bound to a non-UTF-8 codec.
|
|
|
|
Historically the repair was gated on ``sys.platform == "win32"`` and only
|
|
caught the Windows cp1252 case. Linux hosts with a latin-1 / C / POSIX locale
|
|
(common on minimal Debian installs and Raspberry Pi) hit the identical crash
|
|
in ``hermes setup`` because the repair returned early. See the Raspberry Pi
|
|
report: latin-1 locale → UnicodeEncodeError before the wizard could start.
|
|
"""
|
|
|
|
import io
|
|
import os
|
|
import sys
|
|
|
|
import hermes_cli
|
|
|
|
|
|
# The exact glyphs the setup wizard / banners print (setup.py ~line 2962+).
|
|
_BANNER = "┌─────┐\n│ ⚕ Hermes │\n└─────┘"
|
|
|
|
|
|
class _FakeStream:
|
|
"""Minimal text stream backed by an in-memory byte buffer with a codec.
|
|
|
|
Mirrors how CPython binds sys.stdout to the locale encoding: writes that
|
|
can't be encoded raise UnicodeEncodeError, just like a real latin-1 TTY.
|
|
"""
|
|
|
|
def __init__(self, encoding, *, supports_reconfigure=True):
|
|
self.encoding = encoding
|
|
self._supports_reconfigure = supports_reconfigure
|
|
self.errors = "strict"
|
|
self._buf = io.BytesIO()
|
|
|
|
def write(self, s):
|
|
self._buf.write(s.encode(self.encoding, self.errors))
|
|
return len(s)
|
|
|
|
def flush(self):
|
|
pass
|
|
|
|
def reconfigure(self, *, encoding=None, errors=None):
|
|
if not self._supports_reconfigure:
|
|
raise AttributeError("reconfigure")
|
|
if encoding is not None:
|
|
self.encoding = encoding
|
|
if errors is not None:
|
|
self.errors = errors
|
|
|
|
def getvalue(self):
|
|
return self._buf.getvalue()
|
|
|
|
|
|
def _run_with_streams(monkeypatch, out, err):
|
|
monkeypatch.setattr(sys, "stdout", out, raising=False)
|
|
monkeypatch.setattr(sys, "stderr", err, raising=False)
|
|
hermes_cli._ensure_utf8()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_utf8_stream_left_untouched(monkeypatch):
|
|
"""Already-UTF-8 streams are a no-op: object identity preserved AND the
|
|
process environment is left untouched (no PYTHONUTF8/PYTHONIOENCODING
|
|
burned in on a healthy UTF-8 host)."""
|
|
out = _FakeStream("utf-8")
|
|
err = _FakeStream("utf-8")
|
|
sentinel_out, sentinel_err = out, err
|
|
monkeypatch.delenv("PYTHONUTF8", raising=False)
|
|
monkeypatch.delenv("PYTHONIOENCODING", raising=False)
|
|
_run_with_streams(monkeypatch, out, err)
|
|
assert sys.stdout is sentinel_out
|
|
assert sys.stderr is sentinel_err
|
|
# Healthy UTF-8 host: no environment mutation (minimal footprint).
|
|
assert "PYTHONUTF8" not in os.environ
|
|
assert "PYTHONIOENCODING" not in os.environ
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_fallback_when_reconfigure_unavailable(monkeypatch, tmp_path):
|
|
"""Streams without reconfigure() fall back to reopening the fd as UTF-8."""
|
|
real_path = tmp_path / "out.txt"
|
|
fh = open(real_path, "w", encoding="latin-1")
|
|
|
|
class _NoReconfigure:
|
|
"""latin-1 stream exposing a real fileno() but no reconfigure()."""
|
|
|
|
encoding = "latin-1"
|
|
|
|
def fileno(self):
|
|
return fh.fileno()
|
|
|
|
stream = _NoReconfigure()
|
|
monkeypatch.setattr(sys, "stdout", stream, raising=False)
|
|
monkeypatch.setattr(sys, "stderr", stream, raising=False)
|
|
hermes_cli._ensure_utf8()
|
|
|
|
# Replaced with a new UTF-8 stream object (not reconfigured in place).
|
|
assert sys.stdout is not stream
|
|
assert sys.stdout.encoding.lower().replace("-", "") == "utf8"
|
|
sys.stdout.write(_BANNER)
|
|
sys.stdout.flush()
|
|
fh.close()
|
|
assert "⚕".encode("utf-8") in real_path.read_bytes()
|
|
|
|
|
|
|
|
|