mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
62 lines
1.8 KiB
Python
62 lines
1.8 KiB
Python
"""`hermes update` must self-heal the ``hermes-acp`` launcher.
|
|
|
|
ACP hosts (Zed, JetBrains, Buzz Desktop) resolve the agent by the
|
|
``hermes-acp`` command name on the login-shell PATH. Fresh installs get the
|
|
launcher from ``scripts/install.sh``; existing installs get it from
|
|
``_ensure_acp_launcher()`` during ``hermes update``.
|
|
"""
|
|
|
|
import os
|
|
import stat
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.main import _ensure_acp_launcher
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_home(tmp_path, monkeypatch):
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
|
|
bin_dir = tmp_path / ".local" / "bin"
|
|
bin_dir.mkdir(parents=True)
|
|
return bin_dir
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_does_not_follow_symlink_into_venv(fake_home, tmp_path):
|
|
"""#21454 failure mode: never write through a symlinked hermes-acp."""
|
|
(fake_home / "hermes").write_text("#!/bin/sh\n", encoding="utf-8")
|
|
console_script = tmp_path / "venv" / "bin" / "hermes-acp"
|
|
console_script.parent.mkdir(parents=True)
|
|
marker = "#!/usr/bin/env python\n# real console script\n"
|
|
console_script.write_text(marker, encoding="utf-8")
|
|
(fake_home / "hermes-acp").symlink_to(console_script)
|
|
|
|
_ensure_acp_launcher()
|
|
|
|
assert console_script.read_text(encoding="utf-8") == marker
|
|
assert (fake_home / "hermes-acp").is_symlink()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_unwritable_bin_dir_is_skipped(fake_home):
|
|
(fake_home / "hermes").write_text("#!/bin/sh\n", encoding="utf-8")
|
|
if os.geteuid() == 0:
|
|
pytest.skip("root ignores directory write permissions")
|
|
fake_home.chmod(0o555)
|
|
try:
|
|
_ensure_acp_launcher() # must not raise
|
|
assert not (fake_home / "hermes-acp").exists()
|
|
finally:
|
|
fake_home.chmod(0o755)
|