mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
46 lines
1.9 KiB
Python
46 lines
1.9 KiB
Python
from unittest.mock import patch
|
|
|
|
|
|
|
|
|
|
def test_find_install_script_from_checkout(tmp_path):
|
|
"""_find_install_script finds scripts/install.sh in a git checkout."""
|
|
from hermes_cli.dep_ensure import _find_install_script
|
|
scripts_dir = tmp_path / "scripts"
|
|
scripts_dir.mkdir()
|
|
(scripts_dir / "install.sh").write_text("#!/bin/bash", encoding="utf-8")
|
|
with patch("hermes_cli.dep_ensure._IS_WINDOWS", False):
|
|
path, shell = _find_install_script(package_dir=tmp_path / "hermes_cli", repo_root=tmp_path)
|
|
assert path is not None
|
|
assert path.name == "install.sh"
|
|
assert shell == "bash"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_ensure_dependency_uses_powershell_on_windows(tmp_path):
|
|
from hermes_cli.dep_ensure import ensure_dependency
|
|
scripts_dir = tmp_path / "scripts"
|
|
scripts_dir.mkdir(parents=True)
|
|
(scripts_dir / "install.ps1").write_text("# fake")
|
|
with patch("hermes_cli.dep_ensure._IS_WINDOWS", True), \
|
|
patch("hermes_cli.dep_ensure._DEP_CHECKS", {"node": lambda: False}), \
|
|
patch("hermes_cli.dep_ensure._find_install_script", return_value=(scripts_dir / "install.ps1", "powershell")), \
|
|
patch("hermes_cli.dep_ensure.shutil") as mock_shutil, \
|
|
patch("hermes_constants.get_hermes_home", return_value=tmp_path / "fakehome"), \
|
|
patch("subprocess.run") as mock_run, \
|
|
patch("sys.stdin") as mock_stdin:
|
|
mock_shutil.which.side_effect = lambda name: "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe" if name == "powershell" else None
|
|
mock_stdin.isatty.return_value = False
|
|
mock_run.return_value = type("R", (), {"returncode": 0})()
|
|
ensure_dependency("node", interactive=False)
|
|
cmd = mock_run.call_args[0][0]
|
|
assert "powershell" in cmd[0].lower()
|
|
assert "-Ensure" in cmd
|
|
assert cmd[cmd.index("-Ensure") + 1] == "node"
|
|
assert "-HermesHome" in cmd
|
|
assert str(tmp_path / "fakehome") in cmd
|