mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
60 lines
2.1 KiB
Python
60 lines
2.1 KiB
Python
"""Regression test: `hermes dashboard --tui` must not hard-crash.
|
|
|
|
Older Hermes desktop app shells (<= 0.15.x) spawn the backend as::
|
|
|
|
hermes dashboard --no-open --tui --host 127.0.0.1 --port <PORT>
|
|
|
|
The ``--tui`` flag was removed from the ``dashboard`` subcommand in cae6b5486
|
|
(embedded chat is always on now). When a user's CLI updates past that commit
|
|
but their desktop app binary has not, argparse used to reject the unknown flag
|
|
with ``error: unrecognized arguments: --tui`` and ``exit(2)`` — the backend
|
|
died before it became ready and the desktop GUI showed only "Hermes couldn't
|
|
start" with no actionable cause.
|
|
|
|
The fix adds a hidden, deprecated, accepted-and-ignored ``--tui`` flag to the
|
|
dashboard subparser so an old app shell + new CLI degrades gracefully instead
|
|
of bricking. These tests pin that contract.
|
|
"""
|
|
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
|
|
REPO_ROOT = os.path.abspath(
|
|
os.path.join(os.path.dirname(__file__), os.pardir, os.pardir)
|
|
)
|
|
|
|
|
|
def _run_cli(args, timeout=60):
|
|
"""Invoke the real hermes_cli.main parser in a subprocess.
|
|
|
|
Uses ``--status`` so the dashboard command exits immediately after parsing
|
|
(it scans the process table and returns) instead of starting a server.
|
|
Returns the CompletedProcess.
|
|
"""
|
|
env = dict(os.environ)
|
|
env["PYTHONPATH"] = REPO_ROOT + os.pathsep + env.get("PYTHONPATH", "")
|
|
return subprocess.run(
|
|
[sys.executable, "-m", "hermes_cli.main", *args],
|
|
cwd=REPO_ROOT,
|
|
env=env,
|
|
capture_output=True,
|
|
text=True,
|
|
timeout=timeout,
|
|
)
|
|
|
|
|
|
def test_dashboard_tui_flag_is_accepted_not_rejected():
|
|
"""The exact argv an old desktop app sends must parse without argparse error."""
|
|
result = _run_cli(
|
|
["dashboard", "--no-open", "--tui", "--host", "127.0.0.1",
|
|
"--port", "39997", "--status"]
|
|
)
|
|
combined = (result.stdout or "") + (result.stderr or "")
|
|
# The pre-fix failure signature.
|
|
assert "unrecognized arguments" not in combined, combined
|
|
assert "--tui" not in (result.stderr or ""), result.stderr
|
|
# argparse usage errors exit 2; the parse itself must not be that error.
|
|
assert result.returncode != 2, combined
|
|
|
|
|