mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
45 lines
1.3 KiB
Python
45 lines
1.3 KiB
Python
"""Contract test for the StubAuthProvider used in dashboard-auth E2E tests.
|
|
|
|
Phase 2 of the dashboard-OAuth plan. Validates the stub against the
|
|
provider protocol so subsequent phases that depend on its behavior
|
|
have a guarantee.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.dashboard_auth.base import (
|
|
InvalidCodeError, RefreshExpiredError, assert_protocol_compliance,
|
|
)
|
|
from tests.hermes_cli.conftest_dashboard_auth import StubAuthProvider
|
|
|
|
|
|
def _pkce_payload(ls) -> dict:
|
|
"""Parse ``state=...;verifier=...`` out of the LoginStart cookie payload."""
|
|
return dict(
|
|
item.split("=", 1)
|
|
for item in ls.cookie_payload["hermes_session_pkce"].split(";")
|
|
)
|
|
|
|
|
|
def test_stub_complies_with_protocol():
|
|
assert assert_protocol_compliance(StubAuthProvider) is None
|
|
|
|
|
|
def test_stub_complete_login_rejects_mismatched_state():
|
|
p = StubAuthProvider()
|
|
p.start_login(redirect_uri="https://x.fly.dev/auth/callback")
|
|
with pytest.raises(InvalidCodeError):
|
|
p.complete_login(
|
|
code="stub_code",
|
|
state="WRONG",
|
|
code_verifier="anything",
|
|
redirect_uri="https://x.fly.dev/auth/callback",
|
|
)
|
|
|
|
|
|
def test_stub_verify_tampered_token_returns_none():
|
|
p = StubAuthProvider()
|
|
assert p.verify_session(access_token="garbage-not-a-real-token") is None
|
|
|
|
|