mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
127 lines
3.1 KiB
Python
127 lines
3.1 KiB
Python
"""Contract test for DashboardAuthProvider implementations.
|
|
|
|
Every provider plugin should call ``assert_protocol_compliance`` on its
|
|
provider class in its own unit test. This module tests the abstract base
|
|
itself: dataclass fields, ABC rejection of partial impls, and the
|
|
protocol-compliance helper.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.dashboard_auth.base import (
|
|
DashboardAuthProvider,
|
|
Session,
|
|
LoginStart,
|
|
assert_protocol_compliance,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Dataclasses
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_session_has_required_fields():
|
|
s = Session(
|
|
user_id="u1",
|
|
email="a@b.com",
|
|
display_name="A",
|
|
org_id="org_1",
|
|
provider="test",
|
|
expires_at=1234567890,
|
|
access_token="at",
|
|
refresh_token="rt",
|
|
)
|
|
assert s.user_id == "u1"
|
|
assert s.provider == "test"
|
|
assert s.expires_at == 1234567890
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# ABC enforcement
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
class _BrokenProvider(DashboardAuthProvider):
|
|
name = "broken"
|
|
display_name = "Broken"
|
|
# Deliberately missing all the methods.
|
|
|
|
|
|
class _CompliantProvider(DashboardAuthProvider):
|
|
name = "ok"
|
|
display_name = "OK"
|
|
|
|
def start_login(self, *, redirect_uri: str) -> LoginStart:
|
|
return LoginStart(redirect_url="x", cookie_payload={})
|
|
|
|
def complete_login(self, *, code, state, code_verifier, redirect_uri) -> Session:
|
|
return Session(
|
|
user_id="u", email="x", display_name="x", org_id="o",
|
|
provider=self.name, expires_at=0,
|
|
access_token="a", refresh_token="r",
|
|
)
|
|
|
|
def verify_session(self, *, access_token: str):
|
|
return None
|
|
|
|
def refresh_session(self, *, refresh_token: str) -> Session:
|
|
return Session(
|
|
user_id="u", email="x", display_name="x", org_id="o",
|
|
provider=self.name, expires_at=0,
|
|
access_token="a", refresh_token="r",
|
|
)
|
|
|
|
def revoke_session(self, *, refresh_token: str) -> None:
|
|
return None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Registry (Task 1.2)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
from hermes_cli.dashboard_auth import ( # noqa: E402 (after-imports for clarity)
|
|
register_provider,
|
|
get_provider,
|
|
list_providers,
|
|
clear_providers,
|
|
)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolated_registry():
|
|
"""Every test starts with an empty registry and leaves it empty."""
|
|
clear_providers()
|
|
yield
|
|
clear_providers()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_registry_lists_in_registration_order():
|
|
class A(_CompliantProvider):
|
|
name = "a"
|
|
display_name = "A"
|
|
|
|
class B(_CompliantProvider):
|
|
name = "b"
|
|
display_name = "B"
|
|
|
|
register_provider(A())
|
|
register_provider(B())
|
|
names = [p.name for p in list_providers()]
|
|
assert names == ["a", "b"]
|
|
|
|
|