mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
147 lines
5.4 KiB
Python
147 lines
5.4 KiB
Python
"""Regression tests for custom_providers per-model context_length resolution.
|
|
|
|
Covers the fix for #15779 — mid-session /model switch to a named custom
|
|
provider must honor ``custom_providers[].models.<id>.context_length`` the
|
|
same way startup already does.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.config import get_custom_provider_context_length
|
|
|
|
|
|
class TestGetCustomProviderContextLength:
|
|
|
|
def test_trailing_slash_insensitive(self):
|
|
custom = [
|
|
{
|
|
"base_url": "https://example.invalid/v1/",
|
|
"models": {"m": {"context_length": 500_000}},
|
|
}
|
|
]
|
|
# config has trailing slash, runtime doesn't — must match
|
|
assert (
|
|
get_custom_provider_context_length(
|
|
"m", "https://example.invalid/v1", custom
|
|
)
|
|
== 500_000
|
|
)
|
|
# and the reverse
|
|
custom2 = [
|
|
{
|
|
"base_url": "https://example.invalid/v1",
|
|
"models": {"m": {"context_length": 500_000}},
|
|
}
|
|
]
|
|
assert (
|
|
get_custom_provider_context_length(
|
|
"m", "https://example.invalid/v1/", custom2
|
|
)
|
|
== 500_000
|
|
)
|
|
|
|
|
|
def test_empty_inputs_return_none(self):
|
|
assert get_custom_provider_context_length("", "http://x", [{"base_url": "http://x", "models": {"": {"context_length": 1}}}]) is None
|
|
assert get_custom_provider_context_length("m", "", [{"base_url": "", "models": {"m": {"context_length": 1}}}]) is None
|
|
assert get_custom_provider_context_length("m", "http://x", None) is None
|
|
assert get_custom_provider_context_length("m", "http://x", []) is None
|
|
|
|
|
|
|
|
class TestGetModelContextLengthHonorsOverride:
|
|
"""agent.model_metadata.get_model_context_length must honor the
|
|
custom_providers override at step 0b — before any probe, cache hit,
|
|
or models.dev lookup can override it.
|
|
"""
|
|
|
|
def _mock_all_probes(self):
|
|
"""Context manager that disables every downstream resolution step."""
|
|
from agent import model_metadata as _mm
|
|
return [
|
|
patch.object(_mm, "get_cached_context_length", return_value=None),
|
|
patch.object(_mm, "fetch_endpoint_model_metadata", return_value={}),
|
|
patch.object(_mm, "fetch_model_metadata", return_value={}),
|
|
patch.object(_mm, "is_local_endpoint", return_value=False),
|
|
patch.object(_mm, "_is_known_provider_base_url", return_value=False),
|
|
]
|
|
|
|
def test_custom_providers_override_wins_over_default_fallback(self):
|
|
from agent.model_metadata import get_model_context_length
|
|
custom = [
|
|
{
|
|
"base_url": "https://example.invalid/v1",
|
|
"models": {"gpt-5.5": {"context_length": 1_050_000}},
|
|
}
|
|
]
|
|
patches = self._mock_all_probes()
|
|
for p in patches:
|
|
p.start()
|
|
try:
|
|
ctx = get_model_context_length(
|
|
"gpt-5.5",
|
|
base_url="https://example.invalid/v1",
|
|
provider="custom",
|
|
custom_providers=custom,
|
|
)
|
|
finally:
|
|
for p in patches:
|
|
p.stop()
|
|
assert ctx == 1_050_000
|
|
|
|
def test_explicit_config_context_length_still_wins(self):
|
|
"""Top-level model.context_length (step 0) outranks custom_providers (step 0b).
|
|
|
|
Users who set both should see the top-level value — that's the
|
|
documented precedence and matches the long-standing step-0 behavior.
|
|
"""
|
|
from agent.model_metadata import get_model_context_length
|
|
custom = [
|
|
{
|
|
"base_url": "https://example.invalid/v1",
|
|
"models": {"m": {"context_length": 1_050_000}},
|
|
}
|
|
]
|
|
ctx = get_model_context_length(
|
|
"m",
|
|
base_url="https://example.invalid/v1",
|
|
provider="custom",
|
|
config_context_length=500_000, # explicit top-level wins
|
|
custom_providers=custom,
|
|
)
|
|
assert ctx == 500_000
|
|
|
|
def test_no_override_falls_through_to_default(self):
|
|
"""With custom_providers=None and all probes disabled, resolver
|
|
returns DEFAULT_FALLBACK_CONTEXT (256K after the stepdown bump).
|
|
"""
|
|
from agent.model_metadata import get_model_context_length, DEFAULT_FALLBACK_CONTEXT
|
|
patches = self._mock_all_probes()
|
|
for p in patches:
|
|
p.start()
|
|
try:
|
|
ctx = get_model_context_length(
|
|
"unknown-model",
|
|
base_url="https://example.invalid/v1",
|
|
provider="custom",
|
|
custom_providers=None,
|
|
)
|
|
finally:
|
|
for p in patches:
|
|
p.stop()
|
|
assert ctx == DEFAULT_FALLBACK_CONTEXT
|
|
|
|
|
|
class TestContextProbeTiers:
|
|
def test_256k_is_top_tier_and_default(self):
|
|
"""The stepdown probe starts at 256K and 256K is the new default."""
|
|
from agent.model_metadata import CONTEXT_PROBE_TIERS, DEFAULT_FALLBACK_CONTEXT
|
|
|
|
assert CONTEXT_PROBE_TIERS[0] == 256_000
|
|
assert DEFAULT_FALLBACK_CONTEXT == 256_000
|
|
# Tiers still descend monotonically
|
|
for a, b in zip(CONTEXT_PROBE_TIERS, CONTEXT_PROBE_TIERS[1:]):
|
|
assert a > b, f"tiers must strictly descend, got {a} then {b}"
|
|
# 128K is still a tier (users relying on it probe-down get there)
|
|
assert 128_000 in CONTEXT_PROBE_TIERS
|