mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
126 lines
3.4 KiB
Python
126 lines
3.4 KiB
Python
"""Tests for `hermes curator status` output.
|
|
|
|
Covers:
|
|
- y0shualee's "least recently active" semantic (view/patch/use all count as activity).
|
|
- The most-used / least-used rankings by activity_count so users can see which
|
|
skills actually get exercised.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
from argparse import Namespace
|
|
from contextlib import redirect_stdout
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
|
|
|
|
|
|
@pytest.fixture
|
|
def curator_status_env(tmp_path, monkeypatch):
|
|
"""Isolated HERMES_HOME with real agent-created skills on disk."""
|
|
home = tmp_path / ".hermes"
|
|
skills = home / "skills"
|
|
skills.mkdir(parents=True)
|
|
(home / "logs").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
|
|
import importlib
|
|
import hermes_constants
|
|
importlib.reload(hermes_constants)
|
|
from tools import skill_usage
|
|
importlib.reload(skill_usage)
|
|
from agent import curator
|
|
importlib.reload(curator)
|
|
from hermes_cli import curator as curator_cli
|
|
importlib.reload(curator_cli)
|
|
|
|
def _write_skill(name: str) -> None:
|
|
d = skills / name
|
|
d.mkdir()
|
|
(d / "SKILL.md").write_text(
|
|
"---\n"
|
|
f"name: {name}\n"
|
|
"description: test\n"
|
|
"version: 1.0.0\n"
|
|
"metadata:\n"
|
|
" hermes:\n"
|
|
" agent_created: true\n"
|
|
"---\n"
|
|
f"# {name}\n"
|
|
)
|
|
|
|
return {
|
|
"home": home,
|
|
"skills": skills,
|
|
"make_skill": _write_skill,
|
|
"skill_usage": skill_usage,
|
|
"curator_cli": curator_cli,
|
|
}
|
|
|
|
|
|
def _capture_status(curator_cli) -> str:
|
|
buf = io.StringIO()
|
|
with redirect_stdout(buf):
|
|
rc = curator_cli._cmd_status(Namespace())
|
|
assert rc == 0
|
|
return buf.getvalue()
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Unmanaged blind spot + adopt verb
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_adopt_subcommand_is_registered():
|
|
"""The verb must be reachable through the real argparse tree, not just as a
|
|
callable — a handler nobody can dispatch to is dead code."""
|
|
import argparse
|
|
|
|
import hermes_cli.curator as curator_cli
|
|
|
|
parser = argparse.ArgumentParser()
|
|
curator_cli.register_cli(parser)
|
|
|
|
args = parser.parse_args(["adopt", "--all-unmanaged", "--dry-run"])
|
|
assert args.func is curator_cli._cmd_adopt
|
|
assert args.all_unmanaged is True
|
|
assert args.dry_run is True
|
|
assert args.skill == []
|
|
|
|
named = parser.parse_args(["adopt", "alpha", "beta"])
|
|
assert named.skill == ["alpha", "beta"]
|
|
assert named.all_unmanaged is False
|
|
|
|
|
|
def test_list_unmanaged_itemizes_and_explains(curator_status_env):
|
|
"""`status` gives the count; this gives the names plus WHY each is
|
|
unmanaged, so the user can decide what to adopt."""
|
|
env = curator_status_env
|
|
env["make_skill"]("legacy-one")
|
|
env["make_skill"]("managed-one")
|
|
env["skill_usage"].mark_agent_created("managed-one")
|
|
|
|
buf = io.StringIO()
|
|
with redirect_stdout(buf):
|
|
rc = env["curator_cli"]._cmd_list_unmanaged(Namespace())
|
|
out = buf.getvalue()
|
|
|
|
assert rc == 0
|
|
assert "legacy-one" in out
|
|
assert "managed-one" not in out
|
|
assert "no marker" in out or "created_by:null" in out
|
|
assert "curator adopt" in out
|
|
|
|
|