mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
52 lines
1.4 KiB
Python
52 lines
1.4 KiB
Python
"""Tests for `hermes curator run` CLI behavior."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
|
|
def _args(**kwargs):
|
|
values = {
|
|
"dry_run": False,
|
|
"synchronous": False,
|
|
"background": False,
|
|
}
|
|
values.update(kwargs)
|
|
return SimpleNamespace(**values)
|
|
|
|
|
|
def test_run_defaults_to_synchronous(monkeypatch, capsys):
|
|
import agent.curator as curator_state
|
|
import hermes_cli.curator as curator_cli
|
|
|
|
calls = []
|
|
monkeypatch.setattr(curator_state, "is_enabled", lambda: True)
|
|
monkeypatch.setattr(
|
|
curator_state,
|
|
"run_curator_review",
|
|
lambda **kwargs: calls.append(kwargs) or {"auto_transitions": {}},
|
|
)
|
|
|
|
assert curator_cli._cmd_run(_args()) == 0
|
|
|
|
assert calls[0]["synchronous"] is True
|
|
assert calls[0]["dry_run"] is False
|
|
assert "background" not in capsys.readouterr().out
|
|
|
|
|
|
def test_dry_run_default_reports_synchronous_wording(monkeypatch, capsys):
|
|
import agent.curator as curator_state
|
|
import hermes_cli.curator as curator_cli
|
|
|
|
monkeypatch.setattr(curator_state, "is_enabled", lambda: True)
|
|
monkeypatch.setattr(
|
|
curator_state,
|
|
"run_curator_review",
|
|
lambda **kwargs: {"auto_transitions": {}},
|
|
)
|
|
|
|
assert curator_cli._cmd_run(_args(dry_run=True)) == 0
|
|
|
|
out = capsys.readouterr().out
|
|
assert "When the report lands" not in out
|
|
assert "Read the report with `hermes curator status`" in out
|