mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
91 lines
2.9 KiB
Python
91 lines
2.9 KiB
Python
"""Tests for `hermes curator archive` and `hermes curator prune`.
|
|
|
|
Covers:
|
|
- archive refuses pinned skills with an `unpin` hint
|
|
- archive returns 0/1 based on archive_skill() success
|
|
- prune filters pinned and already-archived, applies --days threshold
|
|
- prune falls back to created_at when last_activity_at is null
|
|
- prune --dry-run makes no state changes
|
|
- prune --yes skips confirmation
|
|
- prune --days validation
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
|
|
def _ns(**kwargs):
|
|
return SimpleNamespace(**kwargs)
|
|
|
|
|
|
# ─── archive ────────────────────────────────────────────────────────────────
|
|
|
|
|
|
def test_archive_refuses_pinned(monkeypatch, capsys):
|
|
import hermes_cli.curator as curator_cli
|
|
import tools.skill_usage as skill_usage
|
|
|
|
monkeypatch.setattr(skill_usage, "get_record", lambda name: {"pinned": True})
|
|
called = []
|
|
monkeypatch.setattr(
|
|
skill_usage, "archive_skill",
|
|
lambda name: called.append(name) or (True, "should not get here"),
|
|
)
|
|
|
|
rc = curator_cli._cmd_archive(_ns(skill="pinned-skill"))
|
|
assert rc == 1
|
|
assert called == []
|
|
out = capsys.readouterr().out
|
|
assert "pinned" in out.lower()
|
|
assert "hermes curator unpin" in out
|
|
|
|
|
|
|
|
|
|
# ─── prune ──────────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _mk_record(name, *, idle_days=0, pinned=False, state="active", created_idle_days=None):
|
|
import datetime as _dt
|
|
now = _dt.datetime.now(_dt.timezone.utc)
|
|
last_activity = (now - _dt.timedelta(days=idle_days)).isoformat() if idle_days else None
|
|
created_delta = created_idle_days if created_idle_days is not None else idle_days
|
|
created = (now - _dt.timedelta(days=created_delta)).isoformat()
|
|
return {
|
|
"name": name,
|
|
"state": state,
|
|
"pinned": pinned,
|
|
"last_activity_at": last_activity,
|
|
"created_at": created,
|
|
"activity_count": 0 if idle_days == 0 and last_activity is None else 1,
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ─── argparse wiring ────────────────────────────────────────────────────────
|
|
|
|
|
|
def test_archive_and_prune_registered():
|
|
import argparse
|
|
import hermes_cli.curator as curator_cli
|
|
|
|
parser = argparse.ArgumentParser(prog="hermes curator")
|
|
curator_cli.register_cli(parser)
|
|
|
|
args = parser.parse_args(["archive", "my-skill"])
|
|
assert args.skill == "my-skill"
|
|
assert args.func.__name__ == "_cmd_archive"
|
|
|
|
args = parser.parse_args(["prune", "--days", "45", "--yes", "--dry-run"])
|
|
assert args.days == 45
|
|
assert args.yes is True
|
|
assert args.dry_run is True
|
|
assert args.func.__name__ == "_cmd_prune"
|
|
|
|
|