mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
136 lines
5 KiB
Python
136 lines
5 KiB
Python
"""Tests for Copilot token exchange (raw GitHub token → Copilot API token)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import time
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clear_jwt_cache():
|
|
"""Reset the module-level JWT cache before each test."""
|
|
import hermes_cli.copilot_auth as mod
|
|
mod._jwt_cache.clear()
|
|
yield
|
|
mod._jwt_cache.clear()
|
|
|
|
|
|
class TestExchangeCopilotToken:
|
|
"""Tests for exchange_copilot_token()."""
|
|
|
|
def _mock_urlopen(self, token="tid=abc;exp=123;sku=copilot_individual", expires_at=None):
|
|
"""Create a mock urlopen context manager returning a token response."""
|
|
if expires_at is None:
|
|
expires_at = time.time() + 1800
|
|
resp_data = json.dumps({"token": token, "expires_at": expires_at}).encode()
|
|
mock_resp = MagicMock()
|
|
mock_resp.read.return_value = resp_data
|
|
mock_resp.__enter__ = MagicMock(return_value=mock_resp)
|
|
mock_resp.__exit__ = MagicMock(return_value=False)
|
|
return mock_resp
|
|
|
|
@patch("urllib.request.urlopen")
|
|
def test_exchanges_token_successfully(self, mock_urlopen):
|
|
from hermes_cli.copilot_auth import exchange_copilot_token
|
|
|
|
mock_urlopen.return_value = self._mock_urlopen(token="tid=abc;exp=999")
|
|
api_token, expires_at, base_url = exchange_copilot_token("gho_test123")
|
|
|
|
assert api_token == "tid=abc;exp=999"
|
|
assert isinstance(expires_at, float)
|
|
assert base_url is None # no proxy-ep in this token
|
|
|
|
# Verify request was made with correct headers
|
|
call_args = mock_urlopen.call_args
|
|
req = call_args[0][0]
|
|
assert req.get_header("Authorization") == "token gho_test123"
|
|
assert "GitHubCopilotChat" in req.get_header("User-agent")
|
|
|
|
|
|
|
|
@patch("urllib.request.urlopen")
|
|
def test_raises_on_empty_token(self, mock_urlopen):
|
|
from hermes_cli.copilot_auth import exchange_copilot_token
|
|
|
|
resp_data = json.dumps({"token": "", "expires_at": 0}).encode()
|
|
mock_resp = MagicMock()
|
|
mock_resp.read.return_value = resp_data
|
|
mock_resp.__enter__ = MagicMock(return_value=mock_resp)
|
|
mock_resp.__exit__ = MagicMock(return_value=False)
|
|
mock_urlopen.return_value = mock_resp
|
|
|
|
with pytest.raises(ValueError, match="empty token"):
|
|
exchange_copilot_token("gho_test123")
|
|
|
|
|
|
class TestGetCopilotApiToken:
|
|
"""Tests for get_copilot_api_token() — the fallback wrapper."""
|
|
|
|
@patch("hermes_cli.copilot_auth.exchange_copilot_token")
|
|
def test_returns_exchanged_token(self, mock_exchange):
|
|
from hermes_cli.copilot_auth import get_copilot_api_token
|
|
|
|
mock_exchange.return_value = ("exchanged_jwt", time.time() + 1800, None)
|
|
api_token, base_url = get_copilot_api_token("gho_raw")
|
|
assert api_token == "exchanged_jwt"
|
|
assert base_url is None
|
|
|
|
|
|
class TestTokenFingerprint:
|
|
"""Tests for _token_fingerprint()."""
|
|
|
|
def test_consistent(self):
|
|
from hermes_cli.copilot_auth import _token_fingerprint
|
|
|
|
fp1 = _token_fingerprint("gho_abc123")
|
|
fp2 = _token_fingerprint("gho_abc123")
|
|
assert fp1 == fp2
|
|
|
|
|
|
class TestCallerIntegration:
|
|
"""Test that callers correctly use token exchange."""
|
|
|
|
@patch("hermes_cli.copilot_auth.resolve_copilot_token", return_value=("gho_raw", "GH_TOKEN"))
|
|
@patch("hermes_cli.copilot_auth.get_copilot_api_token", return_value=("exchanged_jwt", None))
|
|
def test_auth_resolve_uses_exchange(self, mock_exchange, mock_resolve):
|
|
from hermes_cli.auth import _resolve_api_key_provider_secret
|
|
|
|
# Create a minimal pconfig mock
|
|
pconfig = MagicMock()
|
|
token, source = _resolve_api_key_provider_secret("copilot", pconfig)
|
|
assert token == "exchanged_jwt"
|
|
assert source == "GH_TOKEN"
|
|
mock_exchange.assert_called_once_with("gho_raw")
|
|
|
|
|
|
class TestDeriveBaseUrlFromProxyEp:
|
|
"""Tests for _derive_base_url_from_proxy_ep()."""
|
|
|
|
def test_extracts_enterprise_url(self):
|
|
from hermes_cli.copilot_auth import _derive_base_url_from_proxy_ep
|
|
|
|
token = "tid=abc;exp=999;proxy-ep=proxy.enterprise.githubcopilot.com;sku=copilot_enterprise"
|
|
assert _derive_base_url_from_proxy_ep(token) == "https://api.enterprise.githubcopilot.com"
|
|
|
|
|
|
|
|
|
|
@patch("urllib.request.urlopen")
|
|
def test_exchange_returns_none_base_url_for_individual(self, mock_urlopen, _clear_jwt_cache):
|
|
"""exchange_copilot_token returns None base_url for individual accounts."""
|
|
from hermes_cli.copilot_auth import exchange_copilot_token
|
|
|
|
token_no_ep = "tid=abc;exp=999;sku=copilot_individual"
|
|
expires_at = time.time() + 1800
|
|
resp_data = json.dumps({"token": token_no_ep, "expires_at": expires_at}).encode()
|
|
mock_resp = MagicMock()
|
|
mock_resp.read.return_value = resp_data
|
|
mock_resp.__enter__ = MagicMock(return_value=mock_resp)
|
|
mock_resp.__exit__ = MagicMock(return_value=False)
|
|
mock_urlopen.return_value = mock_resp
|
|
|
|
api_token, _, base_url = exchange_copilot_token("gho_test")
|
|
assert base_url is None
|