mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
42 lines
1.3 KiB
Python
42 lines
1.3 KiB
Python
"""Portal-URL resolution for Phase 2b billing errors (nous_billing).
|
|
|
|
The server emits ``portalUrl`` relative by design (``/billing?topup=open``); the
|
|
client must resolve it against the active portal base so deep-links are clickable
|
|
on whatever deployment (preview / staging / prod) the user is pointed at.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.nous_billing import (
|
|
BillingError,
|
|
_absolutize_portal_url,
|
|
_raise_for_error,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def _preview(monkeypatch):
|
|
monkeypatch.setenv("HERMES_PORTAL_BASE_URL", "https://nas-pr-412.nousresearch.wtf")
|
|
|
|
|
|
def test_absolutize_resolves_relative(_preview):
|
|
assert (
|
|
_absolutize_portal_url("/billing?topup=open")
|
|
== "https://nas-pr-412.nousresearch.wtf/billing?topup=open"
|
|
)
|
|
|
|
|
|
def test_raise_for_error_attaches_absolute_portal_url(_preview):
|
|
# The 403 no_payment_method envelope carries a RELATIVE portalUrl; the raised
|
|
# BillingError must expose it as ABSOLUTE so CLI + TUI render a clickable link.
|
|
with pytest.raises(BillingError) as exc_info:
|
|
_raise_for_error(
|
|
403,
|
|
{"error": "no_payment_method", "portalUrl": "/billing?topup=open"},
|
|
)
|
|
assert (
|
|
exc_info.value.portal_url
|
|
== "https://nas-pr-412.nousresearch.wtf/billing?topup=open"
|
|
)
|