mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
"""Tests for banner skills display — terminal-width-aware truncation."""
|
|
|
|
import os
|
|
from unittest.mock import patch
|
|
|
|
from rich.console import Console
|
|
|
|
import hermes_cli.banner as banner
|
|
import model_tools
|
|
import tools.mcp_tool
|
|
|
|
|
|
def _build_banner_with_skills(skills_by_category, term_width=160):
|
|
"""Helper: build banner with given skills and return captured output."""
|
|
with (
|
|
patch.object(
|
|
model_tools,
|
|
"check_tool_availability",
|
|
return_value=([], []),
|
|
),
|
|
patch.object(banner, "get_available_skills", return_value=skills_by_category),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
patch("shutil.get_terminal_size", return_value=os.terminal_size((term_width, 50))),
|
|
):
|
|
console = Console(
|
|
record=True, force_terminal=False, color_system=None, width=term_width
|
|
)
|
|
banner.build_welcome_banner(
|
|
console=console,
|
|
model="anthropic/test-model",
|
|
cwd="/tmp/project",
|
|
tools=[],
|
|
)
|
|
return console.export_text()
|
|
|
|
|
|
def test_wide_terminal_shows_more_than_8_skills():
|
|
"""A wide terminal should display more than 8 skills per category."""
|
|
# 15 skills in one category
|
|
skills = {"research": [f"skill-{i:02d}" for i in range(15)]}
|
|
text = _build_banner_with_skills(skills, term_width=200)
|
|
|
|
# With a 200-char terminal, more than 8 should be visible.
|
|
# The old code always truncated at 8; we should see at least 9 now.
|
|
assert "skill-08" in text, f"Expected skill-08 in output for wide terminal: {text}"
|
|
|
|
|
|
def test_small_category_shows_all_skills():
|
|
"""Categories with few skills should show all of them regardless of width."""
|
|
skills = {"security": ["auth", "vault"]}
|
|
text = _build_banner_with_skills(skills, term_width=80)
|
|
|
|
assert "auth" in text
|
|
assert "vault" in text
|
|
# No "+N more" indicator for small categories
|
|
assert "+2 more" not in text
|
|
|
|
|
|
def test_skills_respect_category_label_width():
|
|
"""Skills display should account for the category label prefix width."""
|
|
# A category with a long name should have less room for skills
|
|
skills = {"very-long-category-name": [f"skill-{i:02d}" for i in range(10)]}
|
|
text = _build_banner_with_skills(skills, term_width=120)
|
|
|
|
# Should still show at least some skills
|
|
assert "skill-00" in text
|