mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
33 lines
1.3 KiB
Python
33 lines
1.3 KiB
Python
"""Tests for banner get_available_skills() — disabled and platform filtering."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
_MOCK_SKILLS = [
|
|
{"name": "skill-a", "description": "A skill", "category": "tools"},
|
|
{"name": "skill-b", "description": "B skill", "category": "tools"},
|
|
{"name": "skill-c", "description": "C skill", "category": "creative"},
|
|
]
|
|
|
|
|
|
def test_get_available_skills_delegates_to_find_all_skills():
|
|
"""get_available_skills should call _find_all_skills (which handles filtering)."""
|
|
with patch("tools.skills_tool._find_all_skills", return_value=list(_MOCK_SKILLS)):
|
|
from hermes_cli.banner import get_available_skills
|
|
result = get_available_skills()
|
|
|
|
assert "tools" in result
|
|
assert "creative" in result
|
|
assert sorted(result["tools"]) == ["skill-a", "skill-b"]
|
|
assert result["creative"] == ["skill-c"]
|
|
|
|
|
|
def test_get_available_skills_null_category_becomes_general():
|
|
"""Skills with None category should be grouped under 'general'."""
|
|
skills = [{"name": "orphan-skill", "description": "No cat", "category": None}]
|
|
with patch("tools.skills_tool._find_all_skills", return_value=skills):
|
|
from hermes_cli.banner import get_available_skills
|
|
result = get_available_skills()
|
|
|
|
assert "general" in result
|
|
assert result["general"] == ["orphan-skill"]
|