mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
104 lines
3.5 KiB
Python
104 lines
3.5 KiB
Python
"""Tests for is_provider_explicitly_configured()."""
|
|
|
|
import json
|
|
import pytest
|
|
|
|
|
|
def _write_config(tmp_path, config: dict) -> None:
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir(parents=True, exist_ok=True)
|
|
import yaml
|
|
(hermes_home / "config.yaml").write_text(yaml.dump(config))
|
|
|
|
|
|
def _write_auth_store(tmp_path, payload: dict) -> None:
|
|
hermes_home = tmp_path / "hermes"
|
|
hermes_home.mkdir(parents=True, exist_ok=True)
|
|
(hermes_home / "auth.json").write_text(json.dumps(payload, indent=2))
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_anthropic_env(monkeypatch):
|
|
"""Strip Anthropic env vars so CI secrets don't leak into tests."""
|
|
for key in ("ANTHROPIC_API_KEY", "ANTHROPIC_TOKEN", "CLAUDE_CODE_OAUTH_TOKEN"):
|
|
monkeypatch.delenv(key, raising=False)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_ambient_pool_source_does_not_count_as_explicit(tmp_path, monkeypatch):
|
|
"""gh_cli-seeded Copilot pool entries are ambient, not explicit config (#56974)."""
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes"))
|
|
monkeypatch.delenv("COPILOT_GITHUB_TOKEN", raising=False)
|
|
monkeypatch.delenv("GH_TOKEN", raising=False)
|
|
monkeypatch.delenv("GITHUB_TOKEN", raising=False)
|
|
_write_auth_store(tmp_path, {
|
|
"version": 1,
|
|
"providers": {},
|
|
"active_provider": None,
|
|
"credential_pool": {
|
|
"copilot": [{
|
|
"id": "abc123",
|
|
"source": "gh_cli",
|
|
"auth_type": "api_key",
|
|
"access_token": "ghu_sometoken",
|
|
}],
|
|
},
|
|
})
|
|
|
|
from hermes_cli.auth import is_provider_explicitly_configured
|
|
assert is_provider_explicitly_configured("copilot") is False
|
|
|
|
|
|
def test_returns_true_when_moa_reference_slot_uses_provider(tmp_path, monkeypatch):
|
|
"""MoA advisor slots are explicit provider selections for auth gating."""
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes"))
|
|
_write_config(tmp_path, {
|
|
"model": {"provider": "openai-codex", "default": "gpt-5.5"},
|
|
"moa": {
|
|
"presets": {
|
|
"default": {
|
|
"reference_models": [
|
|
{"provider": "anthropic", "model": "claude-opus-4-8"},
|
|
{"provider": "opencode-go", "model": "glm-5.2"},
|
|
],
|
|
"aggregator": {"provider": "openai-codex", "model": "gpt-5.5"},
|
|
}
|
|
}
|
|
},
|
|
})
|
|
_write_auth_store(tmp_path, {"version": 1, "providers": {}, "active_provider": "openai-codex"})
|
|
|
|
from hermes_cli.auth import is_provider_explicitly_configured
|
|
assert is_provider_explicitly_configured("anthropic") is True
|
|
|
|
|
|
def test_stale_env_pool_entry_does_not_count_when_var_unset(tmp_path, monkeypatch):
|
|
"""An env-seeded pool entry left in auth.json after the env var was removed
|
|
must not mark the provider configured (#55790): the picker showed removed
|
|
providers forever because the record existed even though no secret resolves."""
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes"))
|
|
monkeypatch.delenv("DEEPSEEK_API_KEY", raising=False)
|
|
_write_auth_store(tmp_path, {
|
|
"version": 1,
|
|
"providers": {},
|
|
"active_provider": None,
|
|
"credential_pool": {
|
|
"deepseek": [{
|
|
"id": "aaa111",
|
|
"source": "env:DEEPSEEK_API_KEY",
|
|
"auth_type": "api_key",
|
|
}],
|
|
},
|
|
})
|
|
|
|
from hermes_cli.auth import is_provider_explicitly_configured
|
|
assert is_provider_explicitly_configured("deepseek") is False
|
|
|
|
|
|
|
|
|
|
|
|
|