mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
53 lines
1.6 KiB
Python
53 lines
1.6 KiB
Python
"""Text-debounce batching for the WhatsApp adapter (issue #35301).
|
|
|
|
WhatsApp delivers rapid multi-message bursts (forwarded batches, paste-splits)
|
|
individually. Without debounce each fragment triggers a separate agent
|
|
invocation, wasting tokens and flooding the user with reply fragments. This
|
|
mirrors the Telegram/WeCom/Feishu pattern.
|
|
|
|
Batch delays are read from ``config.extra`` (config.yaml), not env vars.
|
|
"""
|
|
|
|
import asyncio
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
def _make_adapter(**extra):
|
|
base = {"session_name": "test"}
|
|
base.update(extra)
|
|
return WhatsAppAdapter(PlatformConfig(enabled=True, extra=base))
|
|
|
|
|
|
def _event(text):
|
|
src = SessionSource(
|
|
platform=Platform.WHATSAPP,
|
|
chat_id="chat123",
|
|
chat_type="dm",
|
|
user_id="user1",
|
|
user_name="tester",
|
|
)
|
|
return MessageEvent(text=text, message_type=MessageType.TEXT, source=src)
|
|
|
|
|
|
def test_batch_delays_overridden_via_config_extra():
|
|
adapter = _make_adapter(
|
|
text_batch_delay_seconds="2.5",
|
|
text_batch_split_delay_seconds=7,
|
|
)
|
|
assert adapter._text_batch_delay_seconds == 2.5
|
|
assert adapter._text_batch_split_delay_seconds == 7.0
|
|
|
|
|
|
def test_invalid_config_value_falls_back_to_default():
|
|
adapter = _make_adapter(
|
|
text_batch_delay_seconds="garbage",
|
|
text_batch_split_delay_seconds=-3,
|
|
)
|
|
assert adapter._text_batch_delay_seconds == 5.0
|
|
assert adapter._text_batch_split_delay_seconds == 10.0
|
|
|
|
|