mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
75 lines
2.4 KiB
Python
75 lines
2.4 KiB
Python
"""Regression tests for PR #58448 salvage: the documented
|
|
WHATSAPP_CLOUD_ALLOWED_USERS / WHATSAPP_CLOUD_ALLOW_ALL_USERS env vars
|
|
must actually drive the DM intake gate.
|
|
|
|
Before the fix, the adapter only read WHATSAPP_CLOUD_ALLOW_FROM and the
|
|
dm_policy default was "open" (which fails closed without an allow-all
|
|
opt-in), so a wizard-configured install using the documented vars
|
|
silently dropped every inbound message.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform
|
|
|
|
|
|
def _build_adapter(monkeypatch, env: dict[str, str], extra: dict | None = None):
|
|
"""Construct a real WhatsAppCloudAdapter through __init__ with env vars."""
|
|
from gateway.platforms.whatsapp_cloud import WhatsAppCloudAdapter
|
|
|
|
for var in (
|
|
"WHATSAPP_CLOUD_ALLOW_FROM",
|
|
"WHATSAPP_CLOUD_ALLOWED_USERS",
|
|
"WHATSAPP_CLOUD_ALLOW_ALL_USERS",
|
|
"WHATSAPP_CLOUD_DM_POLICY",
|
|
"WHATSAPP_DM_POLICY",
|
|
"GATEWAY_ALLOW_ALL_USERS",
|
|
"WHATSAPP_ALLOW_ALL_USERS",
|
|
):
|
|
monkeypatch.delenv(var, raising=False)
|
|
for key, value in env.items():
|
|
monkeypatch.setenv(key, value)
|
|
|
|
config = MagicMock()
|
|
config.extra = {
|
|
"phone_number_id": "1234567890",
|
|
"access_token": "test-token",
|
|
**(extra or {}),
|
|
}
|
|
return WhatsAppCloudAdapter(config)
|
|
|
|
|
|
def _dm_message(sender: str) -> dict:
|
|
return {"from": sender, "id": "wamid.test", "type": "text"}
|
|
|
|
|
|
def test_allowed_users_env_populates_allowlist_and_enforces_it(monkeypatch):
|
|
adapter = _build_adapter(
|
|
monkeypatch, {"WHATSAPP_CLOUD_ALLOWED_USERS": "15551234567"}
|
|
)
|
|
|
|
# The documented var must populate the allowlist...
|
|
assert "15551234567" in adapter._allow_from
|
|
# ...and flip the default dm_policy to allowlist so it is enforced.
|
|
assert adapter._dm_policy == "allowlist"
|
|
# Allowlisted sender passes the intake gate; others are dropped.
|
|
assert adapter._is_dm_allowed("15551234567") is True
|
|
assert adapter._is_dm_allowed("19998887777") is False
|
|
|
|
|
|
def test_allow_from_still_takes_precedence(monkeypatch):
|
|
adapter = _build_adapter(
|
|
monkeypatch,
|
|
{
|
|
"WHATSAPP_CLOUD_ALLOW_FROM": "15550000001",
|
|
"WHATSAPP_CLOUD_ALLOWED_USERS": "15559999999",
|
|
},
|
|
)
|
|
|
|
# Legacy ALLOW_FROM wins when both are set (documented precedence).
|
|
assert "15550000001" in adapter._allow_from
|
|
assert "15559999999" not in adapter._allow_from
|