mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
60 lines
2.2 KiB
Python
60 lines
2.2 KiB
Python
"""Tests for resolve_whatsapp_bridge_dir() — read-only install tree handling.
|
|
|
|
Regression coverage for #49561: in the Docker image the install tree
|
|
(/opt/hermes/scripts/whatsapp-bridge) is read-only, so `npm install` fails
|
|
with EACCES. The resolver must detect the read-only install dir and mirror the
|
|
bridge source into a writable HERMES_HOME location instead.
|
|
"""
|
|
import importlib
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from gateway.platforms import whatsapp_common
|
|
|
|
|
|
def _seed_install_tree(install_bridge: Path) -> None:
|
|
"""Create a minimal fake bridge source tree."""
|
|
install_bridge.mkdir(parents=True, exist_ok=True)
|
|
(install_bridge / "bridge.js").write_text("// bridge\n")
|
|
(install_bridge / "package.json").write_text('{"name": "whatsapp-bridge"}\n')
|
|
|
|
|
|
def test_readonly_install_mirrors_to_hermes_home(tmp_path, monkeypatch):
|
|
"""A read-only install tree is mirrored into a writable HERMES_HOME."""
|
|
install_root = tmp_path / "install"
|
|
install_bridge = install_root / "scripts" / "whatsapp-bridge"
|
|
_seed_install_tree(install_bridge)
|
|
|
|
hermes_home = tmp_path / "hermes_home"
|
|
hermes_home.mkdir()
|
|
|
|
monkeypatch.setattr(
|
|
whatsapp_common, "__file__",
|
|
str(install_root / "gateway" / "platforms" / "whatsapp_common.py"),
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_constants.get_hermes_home", lambda: hermes_home
|
|
)
|
|
|
|
# Simulate a read-only install tree. chmod(0o555) is unreliable under
|
|
# root (CI/Docker bypass permission bits), so force the write probe to
|
|
# fail by raising on the .write_test touch for the install dir only.
|
|
_real_touch = Path.touch
|
|
|
|
def _fake_touch(self, *a, **kw):
|
|
if self.name == ".write_test" and install_bridge in self.parents:
|
|
raise PermissionError("read-only install tree")
|
|
return _real_touch(self, *a, **kw)
|
|
|
|
monkeypatch.setattr(Path, "touch", _fake_touch)
|
|
|
|
resolved = whatsapp_common.resolve_whatsapp_bridge_dir()
|
|
|
|
expected = hermes_home / "scripts" / "whatsapp-bridge"
|
|
assert resolved == expected
|
|
# Source was mirrored, not symlinked.
|
|
assert (expected / "bridge.js").read_text() == "// bridge\n"
|
|
assert (expected / "package.json").exists()
|
|
|
|
|