mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
103 lines
3.8 KiB
Python
103 lines
3.8 KiB
Python
"""Tests for WeChat iLink typing ticket refresh logic (issue #38085)."""
|
|
|
|
import asyncio
|
|
import time
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def weixin_adapter():
|
|
"""Create a minimal WeixinAdapter with mocked internals for typing tests."""
|
|
from gateway.platforms.weixin import WeixinAdapter, TypingTicketCache
|
|
|
|
config = MagicMock()
|
|
config.extra = {"account_id": "test-account"}
|
|
config.name = "weixin"
|
|
|
|
with patch.object(WeixinAdapter, "__init__", lambda self, cfg: None):
|
|
adapter = WeixinAdapter.__new__(WeixinAdapter)
|
|
adapter._send_session = AsyncMock()
|
|
adapter._token = "test-token"
|
|
adapter._base_url = "https://ilinkai.weixin.qq.com"
|
|
adapter._account_id = "test-account"
|
|
adapter._typing_cache = TypingTicketCache(ttl_seconds=600.0)
|
|
adapter._token_store = MagicMock()
|
|
adapter._token_store.get.return_value = None # no stored context_token
|
|
adapter.platform = MagicMock()
|
|
mock_value = MagicMock()
|
|
mock_value.title.return_value = "Weixin"
|
|
adapter.platform.value = mock_value
|
|
|
|
return adapter
|
|
|
|
|
|
class TestEnsureTypingTicket:
|
|
"""Tests for _ensure_typing_ticket — the fix for stuck typing indicator."""
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_refreshes_when_ticket_expired(self, weixin_adapter):
|
|
"""When the cached ticket has expired, fetch a new one via getConfig."""
|
|
# Insert an expired ticket directly (bypass TTL check)
|
|
weixin_adapter._typing_cache._cache["user-123"] = (
|
|
"old-ticket",
|
|
time.time() - 601, # expired (TTL is 600s)
|
|
)
|
|
|
|
mock_response = {"typing_ticket": "fresh-ticket-xyz"}
|
|
with patch("gateway.platforms.weixin._get_config", new_callable=AsyncMock) as mock_get:
|
|
mock_get.return_value = mock_response
|
|
ticket = await weixin_adapter._ensure_typing_ticket("user-123")
|
|
|
|
assert ticket == "fresh-ticket-xyz"
|
|
mock_get.assert_called_once_with(
|
|
weixin_adapter._send_session,
|
|
base_url=weixin_adapter._base_url,
|
|
token=weixin_adapter._token,
|
|
user_id="user-123",
|
|
context_token=None,
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_uses_stored_context_token_when_available(self, weixin_adapter):
|
|
"""Pass the stored context_token to getConfig when available."""
|
|
weixin_adapter._token_store.get.return_value = "stored-ctx-token"
|
|
|
|
mock_response = {"typing_ticket": "ticket-with-ctx"}
|
|
with patch("gateway.platforms.weixin._get_config", new_callable=AsyncMock) as mock_get:
|
|
mock_get.return_value = mock_response
|
|
ticket = await weixin_adapter._ensure_typing_ticket("user-789")
|
|
|
|
assert ticket == "ticket-with-ctx"
|
|
mock_get.assert_called_once_with(
|
|
weixin_adapter._send_session,
|
|
base_url=weixin_adapter._base_url,
|
|
token=weixin_adapter._token,
|
|
user_id="user-789",
|
|
context_token="stored-ctx-token",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_none_when_getconfig_fails(self, weixin_adapter):
|
|
"""Return None when getConfig raises an exception."""
|
|
with patch("gateway.platforms.weixin._get_config", new_callable=AsyncMock) as mock_get:
|
|
mock_get.side_effect = Exception("network error")
|
|
ticket = await weixin_adapter._ensure_typing_ticket("user-123")
|
|
|
|
assert ticket is None
|
|
|
|
|
|
class TestTypingTicketCache:
|
|
"""Tests for the TypingTicketCache TTL logic."""
|
|
|
|
def test_returns_ticket_when_fresh(self):
|
|
from gateway.platforms.weixin import TypingTicketCache
|
|
cache = TypingTicketCache(ttl_seconds=600.0)
|
|
cache.set("user-1", "ticket-1")
|
|
assert cache.get("user-1") == "ticket-1"
|
|
|
|
|