mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
87 lines
3.1 KiB
Python
87 lines
3.1 KiB
Python
"""Tests for webhook adapter dynamic route loading."""
|
|
|
|
import json
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.webhook import (
|
|
WebhookAdapter,
|
|
_DYNAMIC_ROUTES_FILENAME,
|
|
_INSECURE_NO_AUTH,
|
|
)
|
|
|
|
|
|
def _make_adapter(routes=None, extra=None):
|
|
_extra = extra or {}
|
|
if routes:
|
|
_extra["routes"] = routes
|
|
_extra.setdefault("secret", "test-global-secret")
|
|
config = PlatformConfig(enabled=True, extra=_extra)
|
|
return WebhookAdapter(config)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
|
|
|
|
class TestDynamicRouteLoading:
|
|
def test_no_dynamic_file(self):
|
|
adapter = _make_adapter(routes={"static": {"secret": "s"}})
|
|
adapter._reload_dynamic_routes()
|
|
assert "static" in adapter._routes
|
|
assert len(adapter._dynamic_routes) == 0
|
|
|
|
def test_loads_dynamic_routes(self, tmp_path):
|
|
subs = {"my-hook": {"secret": "dynamic-secret", "prompt": "test", "events": []}}
|
|
(tmp_path / _DYNAMIC_ROUTES_FILENAME).write_text(json.dumps(subs))
|
|
|
|
adapter = _make_adapter(routes={"static": {"secret": "s"}})
|
|
adapter._reload_dynamic_routes()
|
|
assert "my-hook" in adapter._routes
|
|
assert "static" in adapter._routes
|
|
|
|
|
|
class TestDynamicRouteSecretValidation:
|
|
"""Empty/missing secrets must be rejected during hot-reload.
|
|
|
|
Regression for HMAC bypass: prior to the fix, an agent-induced
|
|
dynamic route with `"secret": ""` would be merged into self._routes
|
|
by _reload_dynamic_routes(), then _handle_webhook's
|
|
`if secret and secret != _INSECURE_NO_AUTH` would skip signature
|
|
validation because empty string is falsy. Unauthenticated POSTs
|
|
would then execute the webhook prompt.
|
|
"""
|
|
|
|
def test_empty_secret_rejected(self, tmp_path):
|
|
# Explicit empty-string secret must NOT fall back to the global
|
|
# secret, and the route must be skipped entirely.
|
|
(tmp_path / _DYNAMIC_ROUTES_FILENAME).write_text(
|
|
json.dumps({"evil": {"secret": "", "prompt": "rm -rf"}})
|
|
)
|
|
adapter = _make_adapter() # has global secret
|
|
adapter._reload_dynamic_routes()
|
|
assert "evil" not in adapter._routes
|
|
assert "evil" not in adapter._dynamic_routes
|
|
|
|
def test_missing_secret_no_global_rejected(self, tmp_path):
|
|
(tmp_path / _DYNAMIC_ROUTES_FILENAME).write_text(
|
|
json.dumps({"orphan": {"prompt": "test"}})
|
|
)
|
|
# No global secret configured
|
|
adapter = _make_adapter(extra={"secret": ""})
|
|
adapter._reload_dynamic_routes()
|
|
assert "orphan" not in adapter._routes
|
|
assert "orphan" not in adapter._dynamic_routes
|
|
|
|
def test_missing_secret_inherits_global(self, tmp_path):
|
|
# No per-route secret but a global one is set → route is kept,
|
|
# the global secret protects it. Preserves existing fallback.
|
|
(tmp_path / _DYNAMIC_ROUTES_FILENAME).write_text(
|
|
json.dumps({"valid": {"prompt": "ok"}})
|
|
)
|
|
adapter = _make_adapter() # global secret set
|
|
adapter._reload_dynamic_routes()
|
|
assert "valid" in adapter._routes
|
|
|
|
|