mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
114 lines
4.5 KiB
Python
114 lines
4.5 KiB
Python
"""Tests for gateway weak credential rejection at startup.
|
|
|
|
Ported from openclaw/openclaw#64586: rejects known-weak placeholder
|
|
tokens at gateway startup instead of letting them silently fail
|
|
against platform APIs.
|
|
"""
|
|
|
|
import logging
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig, Platform, _validate_gateway_config
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helper: create a minimal GatewayConfig with one enabled platform
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _make_gateway_config(platform, token, enabled=True, **extra_kwargs):
|
|
"""Create a minimal GatewayConfig-like object for validation testing."""
|
|
from gateway.config import GatewayConfig
|
|
|
|
config = GatewayConfig(platforms={})
|
|
pconfig = PlatformConfig(enabled=enabled, token=token, **extra_kwargs)
|
|
config.platforms[platform] = pconfig
|
|
return config
|
|
|
|
|
|
def _validate_and_return(config):
|
|
"""Call _validate_gateway_config and return the config (mutated in place)."""
|
|
_validate_gateway_config(config)
|
|
return config
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Unit tests: platform token placeholder rejection
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestPlatformTokenPlaceholderGuard:
|
|
"""Verify that _validate_gateway_config disables platforms with placeholder tokens."""
|
|
|
|
def test_rejects_triple_asterisk(self, caplog):
|
|
"""'***' is the .env.example placeholder — should be rejected."""
|
|
config = _make_gateway_config(Platform.TELEGRAM, "***")
|
|
with caplog.at_level(logging.ERROR):
|
|
_validate_and_return(config)
|
|
assert config.platforms[Platform.TELEGRAM].enabled is False
|
|
assert "placeholder" in caplog.text.lower()
|
|
|
|
|
|
def test_accepts_real_token(self, caplog):
|
|
"""A real-looking bot token should pass validation."""
|
|
config = _make_gateway_config(
|
|
Platform.TELEGRAM, "7123456789:AAHdqTcvCH1vGWJxfSeOfSAs0K5PALDsaw"
|
|
)
|
|
with caplog.at_level(logging.ERROR):
|
|
_validate_and_return(config)
|
|
assert config.platforms[Platform.TELEGRAM].enabled is True
|
|
assert "placeholder" not in caplog.text.lower()
|
|
|
|
|
|
def test_disabled_platform_not_checked(self, caplog):
|
|
"""Disabled platforms should not be validated."""
|
|
config = _make_gateway_config(Platform.TELEGRAM, "***", enabled=False)
|
|
with caplog.at_level(logging.ERROR):
|
|
_validate_and_return(config)
|
|
assert "placeholder" not in caplog.text.lower()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Integration test: API server placeholder key on network-accessible host
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestAPIServerPlaceholderKeyGuard:
|
|
"""Verify that the API server rejects placeholder keys on network hosts."""
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_refuses_wildcard_with_short_random_key(self):
|
|
"""A short but non-placeholder key is brute-forceable on a public bind.
|
|
|
|
June 2026 hermes-0day hardening raised the network-bind entropy floor
|
|
from 8 to 16 chars. A 12-char random key (which passed the old guard)
|
|
must now be refused — the API server dispatches terminal-capable agent
|
|
work, so a guessable key is RCE.
|
|
"""
|
|
from gateway.platforms.api_server import APIServerAdapter
|
|
|
|
adapter = APIServerAdapter(
|
|
PlatformConfig(enabled=True, extra={"host": "0.0.0.0", "key": "a1b2c3d4e5f6"})
|
|
)
|
|
result = await adapter.connect()
|
|
assert result is False
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_allows_wildcard_with_strong_key(self):
|
|
"""A 32-char random key clears the entropy floor (connect proceeds past
|
|
the credential guard). We don't assert full startup success here — the
|
|
port/runner setup is environment-dependent — only that the weak-key
|
|
guard does not reject it."""
|
|
from gateway.platforms.api_server import APIServerAdapter
|
|
from hermes_cli.auth import has_usable_secret
|
|
|
|
strong = "0123456789abcdef0123456789abcdef"
|
|
assert has_usable_secret(strong, min_length=16) is True
|
|
adapter = APIServerAdapter(
|
|
PlatformConfig(enabled=True, extra={"host": "0.0.0.0", "key": strong})
|
|
)
|
|
# The credential guard itself accepts the key (start may still fail on
|
|
# later env-specific steps, which is out of scope for this guard test).
|
|
assert adapter._api_key == strong
|