mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
39 lines
1.2 KiB
Python
39 lines
1.2 KiB
Python
"""Regression tests for #60432.
|
|
|
|
``/update`` (and other gateway shutdown paths) must drain in-flight cron jobs
|
|
before ``process_registry.kill_all()`` runs in final-cleanup. Cron work runs on
|
|
a thread-pool worker and is tracked in ``cron.scheduler._running_job_ids``, not
|
|
in ``GatewayRunner._running_agents`` — so a zero-agent drain must still wait
|
|
for cron to finish (or time out and take the interrupt/kill path).
|
|
"""
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from tests.gateway.restart_test_helpers import make_restart_runner
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_drain_active_agents_waits_for_in_flight_cron_jobs():
|
|
runner, _adapter = make_restart_runner()
|
|
runner._running_agents = {}
|
|
|
|
cron_count = [1]
|
|
|
|
def _cron_in_flight():
|
|
return frozenset(f"job-{i}" for i in range(cron_count[0]))
|
|
|
|
async def finish_cron():
|
|
await asyncio.sleep(0.15)
|
|
cron_count[0] = 0
|
|
|
|
with patch("cron.scheduler.get_running_job_ids", side_effect=_cron_in_flight):
|
|
task = asyncio.create_task(finish_cron())
|
|
_snapshot, timed_out = await runner._drain_active_agents(1.0)
|
|
await task
|
|
|
|
assert timed_out is False
|
|
assert _snapshot == {}
|
|
|
|
|